You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/02/15 10:53:08 UTC
[GitHub] [james-project] chibenwa opened a new pull request #298: JAMES-3500 Do not run previous stages upon tests
chibenwa opened a new pull request #298:
URL: https://github.com/apache/james-project/pull/298
The git plugin, enforces, checkstyles and the like are running 3 times (compile, stable tests, unstable tests)
I would like to experiment doing it once: how much do we save?
Here is the difference on a local single project run:
```
interview1@interview1-HP-ProBook-440-G6:~/Documents/james-project$ mvn surefire:test -pl org.apache.james:blob-api -DskipTests
[INFO] Scanning for projects...
[INFO]
[INFO] ---------------------< org.apache.james:blob-api >----------------------
[INFO] Building Apache James :: Server :: Blob :: API 3.6.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-cli) @ blob-api ---
[INFO] Tests are skipped.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.585 s
[INFO] Finished at: 2021-02-15T17:49:53+07:00
[INFO] ------------------------------------------------------------------------
interview1@interview1-HP-ProBook-440-G6:~/Documents/james-project$ mvn test -pl org.apache.james:blob-api -DskipTests
[INFO] Scanning for projects...
[INFO]
[INFO] ---------------------< org.apache.james:blob-api >----------------------
[INFO] Building Apache James :: Server :: Blob :: API 3.6.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- sortpom-maven-plugin:2.12.0:verify (strict-pom-ordering) @ blob-api ---
[INFO] Verifying file /home/interview1/Documents/james-project/server/blob/blob-api/pom.xml
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ blob-api ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ blob-api ---
[INFO]
[INFO] --- git-commit-id-plugin:3.0.1:revision (get-the-git-infos) @ blob-api ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.6.0:process (process-resource-bundles) @ blob-api ---
[INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ blob-api ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /home/interview1/Documents/james-project/server/blob/blob-api/src/main/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ blob-api ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.0:check (default) @ blob-api ---
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @ blob-api ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ blob-api ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ blob-api ---
[INFO] Tests are skipped.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.440 s
[INFO] Finished at: 2021-02-15T17:50:03+07:00
[INFO] ------------------------------------------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #298:
URL: https://github.com/apache/james-project/pull/298#discussion_r595967890
##########
File path: pom.xml
##########
@@ -3605,5 +3607,144 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>ci-test</id>
+ <build>
+ <plugins>
Review comment:
Sorry about the failing build : it didn't fail in my cursory testing
We actually need to wrap this in a `<pluginManagement>` tag otherwise activating the profile enables the non-disabled plugin executions on projects that do not need them and the build fails
Also we probably want to disable the remaining executions I'll add the necessary code in a comment at the right line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] mbaechler merged pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
mbaechler merged pull request #298:
URL: https://github.com/apache/james-project/pull/298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-781222869
>
> But if we explicitly decide to only use surefire as a test runner (and
> perform a scalatest -> junit5 rewrite) that could easily become a
> non-issue.
>
>
I don't think the rewrite is worth it in the short term. We can decide not
to write new tests in Scala test and when a reason comes to work on these
modules include the migration.
What i was thinking of is: when 5 years from now, the project decides to
include another test framework and we have all collectively forgotten that
CI only runs for surefire(and maybe scalatest) executions... Then it could
take a while before someone realizes that CI doesn't validate the build
correctly[1]
That's the one advantage I see to explicitly excluding plugins executions
from the test phase [2] instead of running the surefire execution
explicitly. While it is more work it offers better safety against future
build modification.
The tradeoff being : the build runs too many things (explicitly disable
plugins) vs the build doesn't run enough (explicitly enable plugins)
[1] or maybe I just spent too much time fixing builds and I'm biased :)
[2] I don't mean using skip, I mean overriding the default execution to
force an empty phase so that the plugin is not actually added to the
effective build (which I think would yield 80% of the time saving - to be
confirmed by an actual run)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] mbaechler commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
mbaechler commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-800888623
Looks good ... for a maven solution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-800281436
I missed a few plugins : f29527fac2d is better
I didn't run this on all the modules to check for more plugins to disable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-800770759
Looks sweet :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-804935515
@chibenwa friendly bump :D
alsoI can reopen a PR to integrate the fixes if you want or create a fixup commit on my branch which you can cherry-pick easily whatever suits you best.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-801043110
it was indeed related, have added the necessary changes as comments to the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-781151206
> The downside of the current approach is that using a new plugin for tests would not be automatically picked up by CI...
Agreed.
But if we explicitly decide to only use surefire as a test runner (and perform a scalatest -> junit5 rewrite) that could easily become a non-issue. Scalatest is used in only 2 modules, it's syntax is quitte different and could be confusing at first...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-779289815
Further gains 20 minutes.
Downside: scalatests needs to be explicitly declared in the JenkinsFile to be run
I personnally don't enjoy scalatest much and tend to prefer Junit5 in scala, hence I am personally not disturbed explicitly having to run them, keeping their usage unfrequent and planning a junit5 rewritte for the sake of consistency, but would enjoy the feedback of scala-ists on this topic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-779881468
> it's not possible to exclude these plugins from the test phase instead?
How? I'm hardly a maven expert...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-806446061
:tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael edited a comment on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
Arsnael edited a comment on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-800933325
```
05:49:19,728 [ERROR] error: error while loading Object, Missing dependency 'object scala.native in compiler mirror', required by /modules/java.base/java/lang/Object.class
05:49:19,742 [ERROR] error: scala.reflect.internal.MissingRequirementError: object scala in compiler mirror not found.
05:49:19,743 [ERROR] at scala.reflect.internal.MissingRequirementError$.notFound(MissingRequirementError.scala:24)
05:49:19,744 [ERROR] at scala.reflect.internal.Mirrors$RootsBase.$anonfun$getModuleOrClass$6(Mirrors.scala:66)
05:49:19,744 [ERROR] at scala.reflect.internal.Mirrors$RootsBase.getPackage(Mirrors.scala:66)
05:49:19,744 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackage$lzycompute(Definitions.scala:196)
05:49:19,745 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackage(Definitions.scala:196)
05:49:19,745 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackageClass$lzycompute(Definitions.scala:197)
05:49:19,746 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackageClass(Definitions.scala:197)
05:49:19,746 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.AnyClass$lzycompute(Definitions.scala:285)
05:49:19,747 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.AnyClass(Definitions.scala:285)
05:49:19,747 [ERROR] at scala.tools.nsc.symtab.classfile.ClassfileParser$ClassTypeCompleter.complete(ClassfileParser.scala:1365)
05:49:19,748 [ERROR] at scala.reflect.internal.Symbols$Symbol.completeInfo(Symbols.scala:1559)
05:49:19,748 [ERROR] at scala.reflect.internal.Symbols$Symbol.info(Symbols.scala:1531)
05:49:19,748 [ERROR] at scala.reflect.internal.Symbols$Symbol.initialize(Symbols.scala:1720)
05:49:19,749 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.init(Definitions.scala:1648)
05:49:19,749 [ERROR] at scala.tools.nsc.Global$Run.<init>(Global.scala:1214)
05:49:19,749 [ERROR] at scala.tools.nsc.Driver.doCompile(Driver.scala:47)
05:49:19,749 [ERROR] at scala.tools.nsc.MainClass.doCompile(Main.scala:30)
05:49:19,750 [ERROR] at scala.tools.nsc.Driver.process(Driver.scala:68)
05:49:19,750 [ERROR] at scala.tools.nsc.Driver.main(Driver.scala:82)
05:49:19,750 [ERROR] at scala.tools.nsc.Main.main(Main.scala)
05:49:19,751 [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
05:49:19,751 [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
05:49:19,752 [ERROR] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
05:49:19,752 [ERROR] at java.base/java.lang.reflect.Method.invoke(Method.java:566)
05:49:19,752 [ERROR] at scala_maven_executions.MainHelper.runMain(MainHelper.java:164)
05:49:19,753 [ERROR] at scala_maven_executions.MainWithArgsInFile.main(MainWithArgsInFile.java:26)
[...]
05:49:21,613 [ERROR] Failed to execute goal net.alchim31.maven:scala-maven-plugin:3.4.6:testCompile (scala-test-compile) on project james-server-util: wrap: org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal net.alchim31.maven:scala-maven-plugin:3.4.6:testCompile (scala-test-compile) on project james-server-util: wrap: org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)
```
related or not?
In the benefice of the doubt... test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-800270507
To be honnest i thought you forgot ^^ looks great!
I will update this pr accordingly tomorrow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-800265857
finally took the time to address this : b602878fbd0
```
~/.../james/master >>> mvn test -pl :testing-base -am -P ci-test
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Apache James Project [pom]
[INFO] Apache James :: Testing :: Base [jar]
[INFO]
[INFO] -------------------< org.apache.james:james-project >-------------------
[INFO] Building Apache James Project 3.6.0-SNAPSHOT [1/2]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] -------------------< org.apache.james:testing-base >--------------------
[INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT [2/2]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ testing-base ---
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache James Project 3.6.0-SNAPSHOT:
[INFO]
[INFO] Apache James Project ............................... SUCCESS [ 0.009 s]
[INFO] Apache James :: Testing :: Base .................... SUCCESS [ 0.460 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.469 s
[INFO] Finished at: 2021-03-16T14:37:39+01:00
[INFO] ------------------------------------------------------------------------
```
then
```
~/.../james/master >>> mvn surefire:test -pl :testing-base -am -P ci-test
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Apache James Project [pom]
[INFO] Apache James :: Testing :: Base [jar]
[INFO]
[INFO] -------------------< org.apache.james:james-project >-------------------
[INFO] Building Apache James Project 3.6.0-SNAPSHOT [1/2]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-cli) @ james-project ---
[INFO] No tests to run.
[INFO]
[INFO] -------------------< org.apache.james:testing-base >--------------------
[INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT [2/2]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-cli) @ testing-base ---
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache James Project 3.6.0-SNAPSHOT:
[INFO]
[INFO] Apache James Project ............................... SUCCESS [ 0.299 s]
[INFO] Apache James :: Testing :: Base .................... SUCCESS [ 0.070 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.202 s
[INFO] Finished at: 2021-03-16T14:37:51+01:00
[INFO] ------------------------------------------------------------------------
```
and yes my laptop isn't too fast :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] rouazana commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
rouazana commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-779331736
it's not possible to exclude these plugins from the test phase instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-781128816
I have been experimenting a bit:
```
<profiles>
<profile>
<id>ci-test</id>
<build>
<plugins>
<plugin>
<groupId>com.github.ekryd.sortpom</groupId>
<artifactId>sortpom-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>pl.project13.maven</groupId>
<artifactId>git-commit-id-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-project-info-reports-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-remote-resources-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
```
Then...
```
% mvn test -P ci-test
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< org.apache.james:testing-base >--------------------
[INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- sortpom-maven-plugin:2.12.0:verify (strict-pom-ordering) @ testing-base ---
[INFO] Skipping Sortpom
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ testing-base ---
[INFO] Skipping Rule Enforcement.
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ testing-base ---
[INFO] Skipping Rule Enforcement.
[INFO]
[INFO] --- git-commit-id-plugin:3.0.1:revision (get-the-git-infos) @ testing-base ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.6.0:process (process-resource-bundles) @ testing-base ---
[INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ testing-base ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ testing-base ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.0:check (default) @ testing-base ---
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @ testing-base ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /home/benwa/Documents/apache/james-project/testing/base/src/test/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ testing-base ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ testing-base ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.810 s
[INFO] Finished at: 2021-02-18T14:44:14+07:00
[INFO] ------------------------------------------------------------------------
mvn test -P ci-test 16,09s user 0,53s system 398% cpu 4,167 total
benwa@horizon ..ents/apache/james-project/testing/base (git)-[JAMES-3410-delete-sharing-fix] % mvn test -P ci-test
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< org.apache.james:testing-base >--------------------
[INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- sortpom-maven-plugin:2.12.0:verify (strict-pom-ordering) @ testing-base ---
[INFO] Skipping Sortpom
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ testing-base ---
[INFO] Skipping Rule Enforcement.
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ testing-base ---
[INFO] Skipping Rule Enforcement.
[INFO]
[INFO] --- git-commit-id-plugin:3.0.1:revision (get-the-git-infos) @ testing-base ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.6.0:process (process-resource-bundles) @ testing-base ---
[INFO] Skipping remote resources execution.
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ testing-base ---
[INFO] Skipping the execution.
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ testing-base ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.0:check (default) @ testing-base ---
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @ testing-base ---
[INFO] Not copying test resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ testing-base ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ testing-base ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.299 s
[INFO] Finished at: 2021-02-18T14:45:16+07:00
[INFO] ------------------------------------------------------------------------
mvn test -P ci-test 13,62s user 0,54s system 391% cpu 3,619 total
```
Compared to the default:
```
% mvn test
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< org.apache.james:testing-base >--------------------
[INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- sortpom-maven-plugin:2.12.0:verify (strict-pom-ordering) @ testing-base ---
[INFO] Verifying file /home/benwa/Documents/apache/james-project/testing/base/pom.xml
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ testing-base ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ testing-base ---
[INFO]
[INFO] --- git-commit-id-plugin:3.0.1:revision (get-the-git-infos) @ testing-base ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.6.0:process (process-resource-bundles) @ testing-base ---
[INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ testing-base ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ testing-base ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.0:check (default) @ testing-base ---
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @ testing-base ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /home/benwa/Documents/apache/james-project/testing/base/src/test/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ testing-base ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ testing-base ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.371 s
[INFO] Finished at: 2021-02-18T14:48:14+07:00
[INFO] ------------------------------------------------------------------------
mvn test 16,92s user 0,56s system 390% cpu 4,480 total
```
And to the above proposal:
```
% mvn surefire:test
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< org.apache.james:testing-base >--------------------
[INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-cli) @ testing-base ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.742 s
[INFO] Finished at: 2021-02-18T14:48:52+07:00
[INFO] ------------------------------------------------------------------------
mvn surefire:test 5,80s user 0,22s system 346% cpu 1,741 total
```
I do not think we can yield similar build time enhancements with just skipping plugins execution.
Did you had something else in mind?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-800933325
```
05:49:19,728 [ERROR] error: error while loading Object, Missing dependency 'object scala.native in compiler mirror', required by /modules/java.base/java/lang/Object.class
05:49:19,742 [ERROR] error: scala.reflect.internal.MissingRequirementError: object scala in compiler mirror not found.
05:49:19,743 [ERROR] at scala.reflect.internal.MissingRequirementError$.notFound(MissingRequirementError.scala:24)
05:49:19,744 [ERROR] at scala.reflect.internal.Mirrors$RootsBase.$anonfun$getModuleOrClass$6(Mirrors.scala:66)
05:49:19,744 [ERROR] at scala.reflect.internal.Mirrors$RootsBase.getPackage(Mirrors.scala:66)
05:49:19,744 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackage$lzycompute(Definitions.scala:196)
05:49:19,745 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackage(Definitions.scala:196)
05:49:19,745 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackageClass$lzycompute(Definitions.scala:197)
05:49:19,746 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackageClass(Definitions.scala:197)
05:49:19,746 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.AnyClass$lzycompute(Definitions.scala:285)
05:49:19,747 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.AnyClass(Definitions.scala:285)
05:49:19,747 [ERROR] at scala.tools.nsc.symtab.classfile.ClassfileParser$ClassTypeCompleter.complete(ClassfileParser.scala:1365)
05:49:19,748 [ERROR] at scala.reflect.internal.Symbols$Symbol.completeInfo(Symbols.scala:1559)
05:49:19,748 [ERROR] at scala.reflect.internal.Symbols$Symbol.info(Symbols.scala:1531)
05:49:19,748 [ERROR] at scala.reflect.internal.Symbols$Symbol.initialize(Symbols.scala:1720)
05:49:19,749 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.init(Definitions.scala:1648)
05:49:19,749 [ERROR] at scala.tools.nsc.Global$Run.<init>(Global.scala:1214)
05:49:19,749 [ERROR] at scala.tools.nsc.Driver.doCompile(Driver.scala:47)
05:49:19,749 [ERROR] at scala.tools.nsc.MainClass.doCompile(Main.scala:30)
05:49:19,750 [ERROR] at scala.tools.nsc.Driver.process(Driver.scala:68)
05:49:19,750 [ERROR] at scala.tools.nsc.Driver.main(Driver.scala:82)
05:49:19,750 [ERROR] at scala.tools.nsc.Main.main(Main.scala)
05:49:19,751 [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
05:49:19,751 [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
05:49:19,752 [ERROR] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
05:49:19,752 [ERROR] at java.base/java.lang.reflect.Method.invoke(Method.java:566)
05:49:19,752 [ERROR] at scala_maven_executions.MainHelper.runMain(MainHelper.java:164)
05:49:19,753 [ERROR] at scala_maven_executions.MainWithArgsInFile.main(MainWithArgsInFile.java:26)
```
related or not?
In the benefice of the doubt... test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #298:
URL: https://github.com/apache/james-project/pull/298#discussion_r595968738
##########
File path: pom.xml
##########
@@ -3605,5 +3607,144 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>ci-test</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>check-style</id>
+ <phase>none</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>default-compile</id>
+ <phase>none</phase>
+ </execution>
+ <execution>
+ <id>default-testCompile</id>
+ <phase>none</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-maven</id>
+ <phase>none</phase>
+ </execution>
+ <execution>
+ <id>enforce-maven-version</id>
+ <phase>none</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>build-test-jars</id>
+ <phase>none</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-project-info-reports-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>none</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-remote-resources-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>process-resource-bundles</id>
+ <phase>none</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>default-resources</id>
+ <phase>none</phase>
+ </execution>
+ <execution>
+ <id>default-testResources</id>
+ <phase>none</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-site-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>attach-descriptor</id>
+ <phase>none</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-source-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>attach-sources</id>
+ <phase>none</phase>
+ </execution>
+ </executions>
+ </plugin>
+
+ <plugin>
+ <groupId>pl.project13.maven</groupId>
+ <artifactId>git-commit-id-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>get-the-git-infos</id>
+ <phase>none</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>net.alchim31.maven</groupId>
+ <artifactId>scala-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>scala-compile-first</id>
+ <phase>none</phase>
+ </execution>
Review comment:
the following execution was missed in my initial suggestion
```
<execution>
<id>scala-test-compile</id>
<phase>none</phase>
</execution>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-781120466
> I can't check before Monday for some reason I can't display the diff on mobile and I'm on vacation this week) it should be possible to use maven profiles to control which plugin runs when
No worry, we are not in a rush ^^ We lived with long builds before hence it should not be a blocker. Enjoy your vacations.
> Create a ci-test profile which disables the plugins you don't want to run in the test phase of CI
I will have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-781142351
To get the most of it you probably want to set the phase to none for the
execution instead of using skip (see
https://stackoverflow.com/q/7821152/7898)
But that's going to be much more verbose for the same result. I think I
prefer the current approach. The downside of the current approach is that
using a new plugin for tests would not be automatically picked up by CI...
Le jeu. 18 févr. 2021 à 08:50, Tellier Benoit <no...@github.com> a
écrit :
> I have been experimenting a bit:
>
> <profiles>
> <profile>
> <id>ci-test</id>
> <build>
> <plugins>
> <plugin>
> <groupId>com.github.ekryd.sortpom</groupId>
> <artifactId>sortpom-maven-plugin</artifactId>
> <configuration>
> <skip>true</skip>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-enforcer-plugin</artifactId>
> <configuration>
> <skip>true</skip>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <configuration>
> <skip>true</skip>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-source-plugin</artifactId>
> <configuration>
> <skip>true</skip>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-checkstyle-plugin</artifactId>
> <configuration>
> <skip>true</skip>
> </configuration>
> </plugin>
> <plugin>
> <groupId>pl.project13.maven</groupId>
> <artifactId>git-commit-id-plugin</artifactId>
> <configuration>
> <skip>true</skip>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-project-info-reports-plugin</artifactId>
> <configuration>
> <skip>true</skip>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-remote-resources-plugin</artifactId>
> <configuration>
> <skip>true</skip>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-resources-plugin</artifactId>
> <configuration>
> <skip>true</skip>
> </configuration>
> </plugin>
> </plugins>
> </build>
> </profile>
> </profiles>
>
> Then...
>
> % mvn test -P ci-test
> OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
> [INFO] Scanning for projects...
> [INFO]
> [INFO] -------------------< org.apache.james:testing-base >--------------------
> [INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT
> [INFO] --------------------------------[ jar ]---------------------------------
> [INFO]
> [INFO] --- sortpom-maven-plugin:2.12.0:verify (strict-pom-ordering) @ testing-base ---
> [INFO] Skipping Sortpom
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ testing-base ---
> [INFO] Skipping Rule Enforcement.
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ testing-base ---
> [INFO] Skipping Rule Enforcement.
> [INFO]
> [INFO] --- git-commit-id-plugin:3.0.1:revision (get-the-git-infos) @ testing-base ---
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.6.0:process (process-resource-bundles) @ testing-base ---
> [INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
> [INFO] Copying 3 resources from 1 bundle.
> [INFO]
> [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ testing-base ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 2 resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ testing-base ---
> [INFO] Nothing to compile - all classes are up to date
> [INFO]
> [INFO] --- maven-checkstyle-plugin:3.1.0:check (default) @ testing-base ---
> [INFO]
> [INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @ testing-base ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory /home/benwa/Documents/apache/james-project/testing/base/src/test/resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ testing-base ---
> [INFO] No sources to compile
> [INFO]
> [INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ testing-base ---
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 2.810 s
> [INFO] Finished at: 2021-02-18T14:44:14+07:00
> [INFO] ------------------------------------------------------------------------
> mvn test -P ci-test 16,09s user 0,53s system 398% cpu 4,167 total
> benwa@horizon ..ents/apache/james-project/testing/base (git)-[JAMES-3410-delete-sharing-fix] % mvn test -P ci-test
> OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
> [INFO] Scanning for projects...
> [INFO]
> [INFO] -------------------< org.apache.james:testing-base >--------------------
> [INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT
> [INFO] --------------------------------[ jar ]---------------------------------
> [INFO]
> [INFO] --- sortpom-maven-plugin:2.12.0:verify (strict-pom-ordering) @ testing-base ---
> [INFO] Skipping Sortpom
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ testing-base ---
> [INFO] Skipping Rule Enforcement.
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ testing-base ---
> [INFO] Skipping Rule Enforcement.
> [INFO]
> [INFO] --- git-commit-id-plugin:3.0.1:revision (get-the-git-infos) @ testing-base ---
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.6.0:process (process-resource-bundles) @ testing-base ---
> [INFO] Skipping remote resources execution.
> [INFO]
> [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ testing-base ---
> [INFO] Skipping the execution.
> [INFO]
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ testing-base ---
> [INFO] Nothing to compile - all classes are up to date
> [INFO]
> [INFO] --- maven-checkstyle-plugin:3.1.0:check (default) @ testing-base ---
> [INFO]
> [INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @ testing-base ---
> [INFO] Not copying test resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ testing-base ---
> [INFO] No sources to compile
> [INFO]
> [INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ testing-base ---
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 2.299 s
> [INFO] Finished at: 2021-02-18T14:45:16+07:00
> [INFO] ------------------------------------------------------------------------
> mvn test -P ci-test 13,62s user 0,54s system 391% cpu 3,619 total
>
> Compared to the default:
>
> % mvn test
> OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
> [INFO] Scanning for projects...
> [INFO]
> [INFO] -------------------< org.apache.james:testing-base >--------------------
> [INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT
> [INFO] --------------------------------[ jar ]---------------------------------
> [INFO]
> [INFO] --- sortpom-maven-plugin:2.12.0:verify (strict-pom-ordering) @ testing-base ---
> [INFO] Verifying file /home/benwa/Documents/apache/james-project/testing/base/pom.xml
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ testing-base ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ testing-base ---
> [INFO]
> [INFO] --- git-commit-id-plugin:3.0.1:revision (get-the-git-infos) @ testing-base ---
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.6.0:process (process-resource-bundles) @ testing-base ---
> [INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
> [INFO] Copying 3 resources from 1 bundle.
> [INFO]
> [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ testing-base ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 2 resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ testing-base ---
> [INFO] Nothing to compile - all classes are up to date
> [INFO]
> [INFO] --- maven-checkstyle-plugin:3.1.0:check (default) @ testing-base ---
> [INFO]
> [INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @ testing-base ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory /home/benwa/Documents/apache/james-project/testing/base/src/test/resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ testing-base ---
> [INFO] No sources to compile
> [INFO]
> [INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ testing-base ---
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3.371 s
> [INFO] Finished at: 2021-02-18T14:48:14+07:00
> [INFO] ------------------------------------------------------------------------
> mvn test 16,92s user 0,56s system 390% cpu 4,480 total
>
> And to the above proposal:
>
> % mvn surefire:test
> OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
> [INFO] Scanning for projects...
> [INFO]
> [INFO] -------------------< org.apache.james:testing-base >--------------------
> [INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT
> [INFO] --------------------------------[ jar ]---------------------------------
> [INFO]
> [INFO] --- maven-surefire-plugin:2.22.2:test (default-cli) @ testing-base ---
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 0.742 s
> [INFO] Finished at: 2021-02-18T14:48:52+07:00
> [INFO] ------------------------------------------------------------------------
> mvn surefire:test 5,80s user 0,22s system 346% cpu 1,741 total
>
> I do not think we can yield similar build time enhancements with just
> skipping plugins execution.
>
> Did you had something else in mind?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/james-project/pull/298#issuecomment-781128816>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAFTQYMOB33MC37U4FLZYTS7TBDPANCNFSM4XUPBE2A>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-781117158
I can't check before Monday for some reason I can't display the diff on mobile and I'm on vacation this week) it should be possible to use maven profiles to control which plugin runs when
You would keep the existing config by default
Create a ci-test profile which disables the plugins you don't want to run in the test phase of CI
I added 2 profiles recently
- to apply dependency sorting automatically
- to filter stable and unstable tests
So there are a few examples in the pom files already
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa edited a comment on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
chibenwa edited a comment on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-781128816
I have been experimenting a bit:
```
<profiles>
<profile>
<id>ci-test</id>
<build>
<plugins>
<plugin>
<groupId>com.github.ekryd.sortpom</groupId>
<artifactId>sortpom-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>pl.project13.maven</groupId>
<artifactId>git-commit-id-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-project-info-reports-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-remote-resources-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
```
Then...
```
benwa@horizon ..ents/apache/james-project/testing/base (git)-[JAMES-3410-delete-sharing-fix] % mvn test -P ci-test
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< org.apache.james:testing-base >--------------------
[INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- sortpom-maven-plugin:2.12.0:verify (strict-pom-ordering) @ testing-base ---
[INFO] Skipping Sortpom
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ testing-base ---
[INFO] Skipping Rule Enforcement.
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ testing-base ---
[INFO] Skipping Rule Enforcement.
[INFO]
[INFO] --- git-commit-id-plugin:3.0.1:revision (get-the-git-infos) @ testing-base ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.6.0:process (process-resource-bundles) @ testing-base ---
[INFO] Skipping remote resources execution.
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ testing-base ---
[INFO] Skipping the execution.
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ testing-base ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.0:check (default) @ testing-base ---
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @ testing-base ---
[INFO] Not copying test resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ testing-base ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ testing-base ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.299 s
[INFO] Finished at: 2021-02-18T14:45:16+07:00
[INFO] ------------------------------------------------------------------------
mvn test -P ci-test 13,62s user 0,54s system 391% cpu 3,619 total
```
Compared to the default:
```
% mvn test
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< org.apache.james:testing-base >--------------------
[INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- sortpom-maven-plugin:2.12.0:verify (strict-pom-ordering) @ testing-base ---
[INFO] Verifying file /home/benwa/Documents/apache/james-project/testing/base/pom.xml
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ testing-base ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ testing-base ---
[INFO]
[INFO] --- git-commit-id-plugin:3.0.1:revision (get-the-git-infos) @ testing-base ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.6.0:process (process-resource-bundles) @ testing-base ---
[INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ testing-base ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ testing-base ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.0:check (default) @ testing-base ---
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @ testing-base ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /home/benwa/Documents/apache/james-project/testing/base/src/test/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ testing-base ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ testing-base ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.371 s
[INFO] Finished at: 2021-02-18T14:48:14+07:00
[INFO] ------------------------------------------------------------------------
mvn test 16,92s user 0,56s system 390% cpu 4,480 total
```
And to the above proposal:
```
% mvn surefire:test
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< org.apache.james:testing-base >--------------------
[INFO] Building Apache James :: Testing :: Base 3.6.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-cli) @ testing-base ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.742 s
[INFO] Finished at: 2021-02-18T14:48:52+07:00
[INFO] ------------------------------------------------------------------------
mvn surefire:test 5,80s user 0,22s system 346% cpu 1,741 total
```
I do not think we can yield similar build time enhancements with just skipping plugins execution.
Did you had something else in mind?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #298: JAMES-3500 Do not run previous stages upon tests
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #298:
URL: https://github.com/apache/james-project/pull/298#issuecomment-801008357
It is probably related :
One execution of scala compiler plugin is not disabled and it seems to be
failing
I didn't have time to finish debugging this morning
Le mer. 17 mars 2021 à 10:29, Rene Cordier ***@***.***> a
écrit :
> 05:49:19,728 [ERROR] error: error while loading Object, Missing dependency 'object scala.native in compiler mirror', required by /modules/java.base/java/lang/Object.class
>
> 05:49:19,742 [ERROR] error: scala.reflect.internal.MissingRequirementError: object scala in compiler mirror not found.
>
> 05:49:19,743 [ERROR] at scala.reflect.internal.MissingRequirementError$.notFound(MissingRequirementError.scala:24)
>
> 05:49:19,744 [ERROR] at scala.reflect.internal.Mirrors$RootsBase.$anonfun$getModuleOrClass$6(Mirrors.scala:66)
>
> 05:49:19,744 [ERROR] at scala.reflect.internal.Mirrors$RootsBase.getPackage(Mirrors.scala:66)
>
> 05:49:19,744 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackage$lzycompute(Definitions.scala:196)
>
> 05:49:19,745 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackage(Definitions.scala:196)
>
> 05:49:19,745 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackageClass$lzycompute(Definitions.scala:197)
>
> 05:49:19,746 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackageClass(Definitions.scala:197)
>
> 05:49:19,746 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.AnyClass$lzycompute(Definitions.scala:285)
>
> 05:49:19,747 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.AnyClass(Definitions.scala:285)
>
> 05:49:19,747 [ERROR] at scala.tools.nsc.symtab.classfile.ClassfileParser$ClassTypeCompleter.complete(ClassfileParser.scala:1365)
>
> 05:49:19,748 [ERROR] at scala.reflect.internal.Symbols$Symbol.completeInfo(Symbols.scala:1559)
>
> 05:49:19,748 [ERROR] at scala.reflect.internal.Symbols$Symbol.info(Symbols.scala:1531)
>
> 05:49:19,748 [ERROR] at scala.reflect.internal.Symbols$Symbol.initialize(Symbols.scala:1720)
>
> 05:49:19,749 [ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.init(Definitions.scala:1648)
>
> 05:49:19,749 [ERROR] at scala.tools.nsc.Global$Run.<init>(Global.scala:1214)
>
> 05:49:19,749 [ERROR] at scala.tools.nsc.Driver.doCompile(Driver.scala:47)
>
> 05:49:19,749 [ERROR] at scala.tools.nsc.MainClass.doCompile(Main.scala:30)
>
> 05:49:19,750 [ERROR] at scala.tools.nsc.Driver.process(Driver.scala:68)
>
> 05:49:19,750 [ERROR] at scala.tools.nsc.Driver.main(Driver.scala:82)
>
> 05:49:19,750 [ERROR] at scala.tools.nsc.Main.main(Main.scala)
>
> 05:49:19,751 [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>
> 05:49:19,751 [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>
> 05:49:19,752 [ERROR] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
> 05:49:19,752 [ERROR] at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>
> 05:49:19,752 [ERROR] at scala_maven_executions.MainHelper.runMain(MainHelper.java:164)
>
> 05:49:19,753 [ERROR] at scala_maven_executions.MainWithArgsInFile.main(MainWithArgsInFile.java:26)
>
> related or not?
>
> In the benefice of the doubt... test this please
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/james-project/pull/298#issuecomment-800933325>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAFTQ3RPBY3F3GLXWSNHKDTEBZAPANCNFSM4XUPBE2A>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org