You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Andreas Pieber (JIRA)" <ji...@apache.org> on 2009/01/27 21:35:02 UTC
[jira] Created: (COCOON3-19) [PATCH] stax-sax converter
[PATCH] stax-sax converter
--------------------------
Key: COCOON3-19
URL: https://issues.apache.org/jira/browse/COCOON3-19
Project: Cocoon 3
Issue Type: Sub-task
Components: cocoon-stax
Reporter: Andreas Pieber
Assignee: Cocoon Developers Team
We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-19) [PATCH] stax-sax converter
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670131#action_12670131 ]
Reinhard Poetz commented on COCOON3-19:
---------------------------------------
Andreas, can you give a pointer to your message sent to the stax-utils community?
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Cocoon Developers Team
> Attachments: cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-19) [PATCH] stax-sax converter
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670233#action_12670233 ]
Andreas Pieber commented on COCOON3-19:
---------------------------------------
The mail I wrote could be found here: https://stax-utils.dev.java.net/servlets/ReadMsg?list=dev&msgNo=298
The mailing list I wrote to was dev@stax-utils.dev.java.net. I'm registered to this list and will post the link to the answer as soon I'll get one (but I'm not sure if I'll ever get one...).
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Reinhard Poetz
> Attachments: cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (COCOON3-19) [PATCH] stax-sax converter
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reinhard Poetz reassigned COCOON3-19:
-------------------------------------
Assignee: Reinhard Poetz (was: Cocoon Developers Team)
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Reinhard Poetz
> Attachments: cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-19) [PATCH] stax-sax converter
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670260#action_12670260 ]
Reinhard Poetz commented on COCOON3-19:
---------------------------------------
Yes, getting a patch with the original license headers would be great. We don't want to keep the SVN because they will be overridden anyway.
Could you also please add a comment of the revision number or release version that those files are taken from?
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Reinhard Poetz
> Attachments: cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON3-19) [PATCH] stax-sax converter
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated COCOON3-19:
----------------------------------
Attachment: cocooon-stax-converter.patch
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Cocoon Developers Team
> Attachments: cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON3-19) [PATCH] stax-sax converter
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reinhard Poetz updated COCOON3-19:
----------------------------------
Fix Version/s: 3.0.0-alpha-2
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Reinhard Poetz
> Fix For: 3.0.0-alpha-2
>
> Attachments: cocoon-stax-license.patch, cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-19) [PATCH] stax-sax converter
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670208#action_12670208 ]
Reinhard Poetz commented on COCOON3-19:
---------------------------------------
I've applied the patch but keep the issue open until the Cocoon PMC has confirmed that I did the licensing part correctly.
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Reinhard Poetz
> Attachments: cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-19) [PATCH] stax-sax converter
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670232#action_12670232 ]
Andreas Pieber commented on COCOON3-19:
---------------------------------------
The stax-utils components directly taken from stax-utils are:
org.apache.cocoon.stax.converter.util.DummyLocator
org.apache.cocoon.stax.converter.util.ExtendedNamespaceContext
org.apache.cocoon.stax.converter.util.SimpleNamespaceContext
org.apache.cocoon.stax.converter.util.StaticNamespaceContext
org.apache.cocoon.stax.converter.util.XMLFilterImplEx
Components which are taken from the stax-utils project, but which were modified are:
org.apache.cocoon.stax.converter.util.StAXEventContentHandler
org.apache.cocoon.stax.converter.util.XMLEventToContentHandler
What do you mean with: "point me to the original license"? The original license from the source code is exactly what you added again with the difference that all of them contain an id like:
$Id: ExtendedNamespaceContext.java,v 1.1 2004/07/05 23:10:46 cniles Exp $
and some of them does not have a sun-copyright header (Copyright (c) 2004, Sun Microsystems, Inc.) but a copyright of the autor itself (Copyright (c) 2004, Christian Niles, unit12.net). Should I change all licenses back to the original and provide a patch?
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Reinhard Poetz
> Attachments: cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-19) [PATCH] stax-sax converter
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670153#action_12670153 ]
Reinhard Poetz commented on COCOON3-19:
---------------------------------------
According to http://www.apache.org/legal/src-headers.html#3party we should not modify or remove any copyright notices or licenses within third-party works. This means we have to keep the original license header (According to https://stax-utils.dev.java.net/ Stax-Utils has a BSD style license) and have to include a reference in the NOTICE file.
Andreas (or anybody else), could you please list all the files that are taken from StAXUtils and point me to the original license? Thanks!
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Cocoon Developers Team
> Attachments: cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (COCOON3-19) [PATCH] stax-sax
converter
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670131#action_12670131 ]
reinhard@apache.org edited comment on COCOON3-19 at 2/3/09 2:45 PM:
---------------------------------------------------------------
Andreas, can you give us a pointer to your message sent to the stax-utils community? (Just for the records)
was (Author: reinhard@apache.org):
Andreas, can you give a pointer to your message sent to the stax-utils community?
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Cocoon Developers Team
> Attachments: cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-19) [PATCH] stax-sax converter
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671466#action_12671466 ]
Reinhard Poetz commented on COCOON3-19:
---------------------------------------
I've just committed the license patch. Thanks!
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Reinhard Poetz
> Attachments: cocoon-stax-license.patch, cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COCOON3-19) [PATCH] stax-sax converter
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reinhard Poetz closed COCOON3-19.
---------------------------------
Resolution: Fixed
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Reinhard Poetz
> Fix For: 3.0.0-alpha-2
>
> Attachments: cocoon-stax-license.patch, cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON3-19) [PATCH] stax-sax converter
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated COCOON3-19:
----------------------------------
Attachment: cocoon-stax-license.patch
There are some classes which have no license in the original code... Namely:
org.apache.cocoon.stax.converter.util.XMLFilterImplEx
org.apache.cocoon.stax.converter.util.StaticNamespaceContext
org.apache.cocoon.stax.converter.util.DummyLocator
What should I do with them? At the moment I did not modify the license there at all and let the sun-header added by you.
Further more I documented where I taken the classes from. I did this in javadoc:
/**
* SAX ContentHandler that writes events to a StAX {@link XMLEventConsumer}.
*
* @author Christian Niles
* @version $Revision: 1.5 $
*
* @version from stax-utils stable version stax-utils-20070216
* @original javanet.staxutils.StAXEventContentHandler, javanet.staxutils.StAXContentHandler
* @modified true (added SAXConsumer and made one class out of StAXEventContentHandler and StAXContentHandler)
*/
public class StAXEventContentHandler extends DefaultHandler implements SAXConsumer {
or would it better to make them inline?
/**
* SAX ContentHandler that writes events to a StAX {@link XMLEventConsumer}.
*
* @author Christian Niles
* @version $Revision: 1.5 $
*/
public class StAXEventContentHandler extends DefaultHandler implements SAXConsumer {
/*
* @version from stax-utils stable version stax-utils-20070216
* @original javanet.staxutils.StAXEventContentHandler, javanet.staxutils.StAXContentHandler
* @modified true (added SAXConsumer and made one class out of StAXEventContentHandler and StAXContentHandler)
*/
> [PATCH] stax-sax converter
> --------------------------
>
> Key: COCOON3-19
> URL: https://issues.apache.org/jira/browse/COCOON3-19
> Project: Cocoon 3
> Issue Type: Sub-task
> Components: cocoon-stax
> Reporter: Andreas Pieber
> Assignee: Reinhard Poetz
> Attachments: cocoon-stax-license.patch, cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/) project. This was required since there's an architectural issue so that stax-utils can not be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago, if they could make some of their methods protected instead of private so that we could resolve this issue, but I did not receive an answer.
> I created a seperated issue for this problem since there's the opened question of how to mark the redistributed classes from the stax-utils project. I think Reinhard know ways of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18 have to be applied before this patch could be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.