You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/02/19 07:44:47 UTC
[GitHub] [trafficserver] maskit opened a new pull request #7542: Fix origin_session_reuse test
maskit opened a new pull request #7542:
URL: https://github.com/apache/trafficserver/pull/7542
The reason of tls_origin_session_reuse failure on autest-master job is TLS version used on the test.
Current test passes only if the connection is TLS 1.3, because a session can be resumed by session id on TLS 1.2.
The box for autest-github has recent OpenSSL and it supports TLS 1.3, so disabling ticket means disabling session reuse.
On the other hand, the box for autest-master has OpenSSL 1.0.2 and it does not support TLS 1.3, so disabling ticket does not mean disabling session reuse.
I confirmed on my laptop that the test fails if I set `proxy.config.ssl.TLSv1_3` to 0 on the test file.
In short, disabling ticket is not enough for disabling session reuse.
On this test, I think we should check that we can disable session reuse at all by setting `origin_session_cache` to 0. In that sense, we may want to have two tests, one for TLS 1.2 and one for TLS 1.3, but I'd like to fix the test failure first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7542: Fix origin_session_reuse test
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7542:
URL: https://github.com/apache/trafficserver/pull/7542#issuecomment-781898308
It's already Friday evening here, and I'll be off next 4 days. Feel free to merge if you approve this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall merged pull request #7542: Fix origin_session_reuse test
Posted by GitBox <gi...@apache.org>.
bryancall merged pull request #7542:
URL: https://github.com/apache/trafficserver/pull/7542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org