You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/18 21:04:45 UTC
Review Request 61752: Audited linkage of 3rdparty dependencies.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61752/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Repository: mesos
Description
-------
This patch forwards the `CMAKE_POSITION_INDEPENDENT_CODE` property to
3rdparty projects built with CMake.
It marks as `GLOBAL` imported (non-interface) libraries to enable Cotire
to find the targets. Note that while "global" is usually frowned upon,
it makes sense for these targets as they would be top-level targets if
they were not also 3rdparty targets, causing us to keep them separate.
It adds `IMPORTED_IMPLIB` locations for dependencies which can be built
as shared libraries (`BUILD_SHARED_LIBS=ON`) so that CMake can link to
them correctly. For the libraries that cannot be built in this way, the
linkage was set explicitly and appropriately (e.g. Googletest must
always be built statically).
Diffs
-----
3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
Diff: https://reviews.apache.org/r/61752/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61752: Audited linkage of 3rdparty dependencies.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61752/#review184463
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Aug. 18, 2017, 2:04 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61752/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 2:04 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch forwards the `CMAKE_POSITION_INDEPENDENT_CODE` property to
> 3rdparty projects built with CMake.
>
> It marks as `GLOBAL` imported (non-interface) libraries to enable Cotire
> to find the targets. Note that while "global" is usually frowned upon,
> it makes sense for these targets as they would be top-level targets if
> they were not also 3rdparty targets, causing us to keep them separate.
>
> It adds `IMPORTED_IMPLIB` locations for dependencies which can be built
> as shared libraries (`BUILD_SHARED_LIBS=ON`) so that CMake can link to
> them correctly. For the libraries that cannot be built in this way, the
> linkage was set explicitly and appropriately (e.g. Googletest must
> always be built statically).
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
>
>
> Diff: https://reviews.apache.org/r/61752/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61752: Audited linkage of 3rdparty dependencies.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61752/#review183262
-----------------------------------------------------------
Bad review!
Reviews applied: [61752, 61751, 61750, 61597, 61516, 61515, 61514, 61513, 61512, 61365]
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 18, 2017, 9:04 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61752/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 9:04 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch forwards the `CMAKE_POSITION_INDEPENDENT_CODE` property to
> 3rdparty projects built with CMake.
>
> It marks as `GLOBAL` imported (non-interface) libraries to enable Cotire
> to find the targets. Note that while "global" is usually frowned upon,
> it makes sense for these targets as they would be top-level targets if
> they were not also 3rdparty targets, causing us to keep them separate.
>
> It adds `IMPORTED_IMPLIB` locations for dependencies which can be built
> as shared libraries (`BUILD_SHARED_LIBS=ON`) so that CMake can link to
> them correctly. For the libraries that cannot be built in this way, the
> linkage was set explicitly and appropriately (e.g. Googletest must
> always be built statically).
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
>
>
> Diff: https://reviews.apache.org/r/61752/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>