You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2022/10/19 11:14:55 UTC
[camel] branch main updated: (chores) Remove useless assignments
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 7d3c863d20f (chores) Remove useless assignments
7d3c863d20f is described below
commit 7d3c863d20f0d6c9a8bd2943e6b172464045daab
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Wed Oct 19 11:24:29 2022 +0200
(chores) Remove useless assignments
---
.../src/main/java/org/apache/camel/maven/RouteCoverageMojo.java | 1 -
.../java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java | 3 +--
.../component/google/bigquery/GoogleBigQueryConfiguration.java | 7 +++----
.../src/main/java/org/apache/camel/component/irc/IrcMessage.java | 2 --
.../camel/dataformat/mime/multipart/MimeMultipartDataFormat.java | 2 --
.../main/java/org/apache/camel/component/netty/NettyProducer.java | 2 --
.../org/apache/camel/component/salesforce/SalesforceComponent.java | 2 --
.../java/org/apache/camel/dsl/jbang/core/common/GistHelper.java | 1 -
.../org/apache/camel/main/download/MavenDependencyDownloader.java | 1 -
9 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/RouteCoverageMojo.java b/catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/RouteCoverageMojo.java
index c65d0efcb3e..0392711bfb8 100644
--- a/catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/RouteCoverageMojo.java
+++ b/catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/RouteCoverageMojo.java
@@ -162,7 +162,6 @@ public class RouteCoverageMojo extends AbstractExecMojo {
try {
// parse the java source code and find Camel RouteBuilder classes
String fqn = file.getPath();
- String baseDir = ".";
JavaType out = Roaster.parse(file);
// we should only parse java classes (not interfaces and enums etc)
if (out instanceof JavaClassSource) {
diff --git a/components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java b/components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java
index dcc59ee63dc..225a4722cf2 100644
--- a/components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java
+++ b/components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java
@@ -389,8 +389,7 @@ public class AWS2S3Producer extends DefaultProducer {
if (ObjectHelper.isEmpty(destinationKey)) {
throw new IllegalArgumentException("Destination Key must be specified for copyObject Operation");
}
- CopyObjectRequest.Builder copyObjectRequest = CopyObjectRequest.builder();
- copyObjectRequest = CopyObjectRequest.builder().destinationBucket(bucketNameDestination)
+ CopyObjectRequest.Builder copyObjectRequest = CopyObjectRequest.builder().destinationBucket(bucketNameDestination)
.destinationKey(destinationKey).copySource(bucketName + "/" + sourceKey);
if (getConfiguration().isUseAwsKMS()) {
diff --git a/components/camel-google/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConfiguration.java b/components/camel-google/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConfiguration.java
index 283a4c558f1..3c01196fbc4 100644
--- a/components/camel-google/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConfiguration.java
+++ b/components/camel-google/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConfiguration.java
@@ -56,11 +56,10 @@ public class GoogleBigQueryConfiguration implements Cloneable {
throw new IllegalArgumentException("Google BigQuery Endpoint format \"projectId:datasetId[:tableName]\"");
}
- int c = 0;
- projectId = parts[c++];
- datasetId = parts[c++];
+ projectId = parts[0];
+ datasetId = parts[1];
if (parts.length > 2) {
- tableId = parts[c++];
+ tableId = parts[3];
}
}
diff --git a/components/camel-irc/src/main/java/org/apache/camel/component/irc/IrcMessage.java b/components/camel-irc/src/main/java/org/apache/camel/component/irc/IrcMessage.java
index 078c56257d3..22d43f60995 100644
--- a/components/camel-irc/src/main/java/org/apache/camel/component/irc/IrcMessage.java
+++ b/components/camel-irc/src/main/java/org/apache/camel/component/irc/IrcMessage.java
@@ -19,7 +19,6 @@ package org.apache.camel.component.irc;
import java.util.Map;
import org.apache.camel.CamelContext;
-import org.apache.camel.Exchange;
import org.apache.camel.support.DefaultMessage;
import org.apache.camel.support.ExchangeHelper;
import org.schwering.irc.lib.IRCUser;
@@ -123,7 +122,6 @@ public class IrcMessage extends DefaultMessage {
@Override
protected Object createBody() {
- Exchange exchange = getExchange();
IrcBinding binding = ExchangeHelper.getBinding(getExchange(), IrcBinding.class);
return binding != null ? binding.extractBodyFromIrc(this) : null;
}
diff --git a/components/camel-mail/src/main/java/org/apache/camel/dataformat/mime/multipart/MimeMultipartDataFormat.java b/components/camel-mail/src/main/java/org/apache/camel/dataformat/mime/multipart/MimeMultipartDataFormat.java
index 8dde0ce98a2..f6f685b4f82 100644
--- a/components/camel-mail/src/main/java/org/apache/camel/dataformat/mime/multipart/MimeMultipartDataFormat.java
+++ b/components/camel-mail/src/main/java/org/apache/camel/dataformat/mime/multipart/MimeMultipartDataFormat.java
@@ -213,7 +213,6 @@ public class MimeMultipartDataFormat extends DefaultDataFormat {
mimeMessage = new MimeBodyPart(stream);
camelMessage = exchange.getMessage();
MessageHelper.copyHeaders(exchange.getIn(), camelMessage, true);
- contentType = mimeMessage.getHeader(CONTENT_TYPE, null);
// write the MIME headers not generated by javamail as Camel headers
Enumeration<?> headersEnum = mimeMessage.getNonMatchingHeaders(STANDARD_HEADERS);
while (headersEnum.hasMoreElements()) {
@@ -253,7 +252,6 @@ public class MimeMultipartDataFormat extends DefaultDataFormat {
dh = mimeMessage.getDataHandler();
if (dh != null) {
content = dh.getContent();
- contentType = dh.getContentType();
}
} catch (MessagingException e) {
LOG.warn("cannot parse message, no unmarshalling done");
diff --git a/components/camel-netty/src/main/java/org/apache/camel/component/netty/NettyProducer.java b/components/camel-netty/src/main/java/org/apache/camel/component/netty/NettyProducer.java
index af376835c48..1e1bc08f667 100644
--- a/components/camel-netty/src/main/java/org/apache/camel/component/netty/NettyProducer.java
+++ b/components/camel-netty/src/main/java/org/apache/camel/component/netty/NettyProducer.java
@@ -57,7 +57,6 @@ import org.apache.camel.util.IOHelper;
import org.apache.commons.pool2.ObjectPool;
import org.apache.commons.pool2.PooledObject;
import org.apache.commons.pool2.PooledObjectFactory;
-import org.apache.commons.pool2.PooledObjectState;
import org.apache.commons.pool2.impl.DefaultPooledObject;
import org.apache.commons.pool2.impl.GenericObjectPool;
import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
@@ -611,7 +610,6 @@ public class NettyProducer extends DefaultAsyncProducer {
ChannelFuture channelFuture = p.getObject();
LOG.trace("activateObject channel request: {}", channelFuture);
- PooledObjectState state = p.getState();
if (channelFuture.isSuccess() && producer.getConfiguration().getRequestTimeout() > 0) {
LOG.trace("Reset the request timeout as we activate the channel");
Channel channel = channelFuture.channel();
diff --git a/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceComponent.java b/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceComponent.java
index bd9d4108be1..6fac729d865 100644
--- a/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceComponent.java
+++ b/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceComponent.java
@@ -33,7 +33,6 @@ import org.apache.camel.component.salesforce.api.SalesforceException;
import org.apache.camel.component.salesforce.api.dto.AbstractDTOBase;
import org.apache.camel.component.salesforce.api.utils.SecurityUtils;
import org.apache.camel.component.salesforce.internal.OperationName;
-import org.apache.camel.component.salesforce.internal.PayloadFormat;
import org.apache.camel.component.salesforce.internal.SalesforceSession;
import org.apache.camel.component.salesforce.internal.client.DefaultRawClient;
import org.apache.camel.component.salesforce.internal.client.DefaultRestClient;
@@ -792,7 +791,6 @@ public class SalesforceComponent extends DefaultComponent implements SSLContextP
RestClient createRestClientFor(SalesforceEndpointConfig endpointConfig) throws SalesforceException {
final String version = endpointConfig.getApiVersion();
- final PayloadFormat format = endpointConfig.getFormat();
return new DefaultRestClient(httpClient, version, session, loginConfig);
}
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/GistHelper.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/GistHelper.java
index bf7fc58ac75..2450c155292 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/GistHelper.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/GistHelper.java
@@ -71,7 +71,6 @@ public final class GistHelper {
if (parts.length < 2) {
return;
}
- String user = parts[0];
String gid = parts[1];
url = "https://api.github.com/gists/" + gid;
diff --git a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/download/MavenDependencyDownloader.java b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/download/MavenDependencyDownloader.java
index 224cdc6d262..c60c2b95793 100644
--- a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/download/MavenDependencyDownloader.java
+++ b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/download/MavenDependencyDownloader.java
@@ -1051,7 +1051,6 @@ public class MavenDependencyDownloader extends ServiceSupport implements Depende
*/
public List<RemoteRepository> configureRemoteRepositories(Settings settings, String repos, boolean fresh) {
List<RemoteRepository> repositories = new ArrayList<>();
- List<RemoteRepository> settingsRepositories = new ArrayList<>();
Set<URL> repositoryURLs = new HashSet<>();