You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Benoit Tellier (Jira)" <se...@james.apache.org> on 2021/09/08 03:10:00 UTC
[jira] [Closed] (JAMES-1808) if (character > 128) should be changed
to if (character >= 128)
[ https://issues.apache.org/jira/browse/JAMES-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benoit Tellier closed JAMES-1808.
---------------------------------
Resolution: Fixed
https://github.com/apache/james-project/pull/634 solved this
> if (character > 128) should be changed to if (character >= 128)
> ---------------------------------------------------------------
>
> Key: JAMES-1808
> URL: https://issues.apache.org/jira/browse/JAMES-1808
> Project: James Server
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: 3.0.0-beta5
> Reporter: Paul Lee
> Priority: Minor
> Fix For: 3.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There is a conditional code block as follows in the class 'ImapResponseComposerImpl' of the package 'org.apache.james.imap.encode.base' in the 'protocols-imap' project.
> // 7-bit ASCII only
> if (character > 128) {
> buffer.write(BYTE_QUESTION);
> } else {
> buffer.write((byte) character);
> }
> An equals(=) sign should be included in the conditional since the range of US-ASCII is from 0 to 127(not including 128).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org