You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/05 22:29:35 UTC

[GitHub] [trafficcontrol] zrhoffman opened a new issue #5816: Ansible roles: Traffic Ops no longer serves static files

zrhoffman opened a new issue #5816:
URL: https://github.com/apache/trafficcontrol/issues/5816


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
   or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
   -->
   
   ## I'm submitting a ...
   <!-- delete all those that don't apply -->
   <!--- security vulnerability (STOP!! - see above)-->
   -  bug report
   
   ## Traffic Control components affected ...
   <!-- delete all those that don't apply -->
   -  Ansible roles
   
   ## Current behavior:
   <!-- Describe how the bug manifests -->
   As mentioned in #5587, Traffic Ops Perl included a static web server for files in the `/opt/traffic_ops/app/public` directory, but Traffic Ops (Golang) does not include this functionality (and TO Perl was removed in #5209). Also, `/opt/traffic_ops/public` itself was removed in #5800.
   
   The Ansible roles still expect to get the MaxMind GeoIP database, coverage zone file, and other static files from Traffic Ops:
   * https://github.com/apache/trafficcontrol/blob/eed246c7854f6f9aefab4b65ce6c35846460e8c9/infrastructure/ansible/roles/dataset_loader/defaults/main.yml#L28
   * https://github.com/apache/trafficcontrol/blob/eed246c7854f6f9aefab4b65ce6c35846460e8c9/infrastructure/ansible/roles/dataset_loader/defaults/main.yml#L30
   * https://github.com/apache/trafficcontrol/blob/eed246c7854f6f9aefab4b65ce6c35846460e8c9/infrastructure/ansible/roles/dataset_loader/defaults/main.yml#L32
   * https://github.com/apache/trafficcontrol/blob/eed246c7854f6f9aefab4b65ce6c35846460e8c9/infrastructure/ansible/roles/dataset_loader/defaults/main.yml#L34
   
   ## Expected behavior:
   <!-- Describe what the behavior would be without the bug -->
   The Ansible roles should reference a new static web server that can host these files.
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on issue #5816: Ansible roles: Traffic Ops no longer serves static files

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #5816:
URL: https://github.com/apache/trafficcontrol/issues/5816#issuecomment-840817056


   IMO only if API updates are necessary to close this Issue. The Issue for updating the Ansible roles to use TO API v4 is #5377.
   
   That said, updating the Ansible roles to use TO API v4 seems like it could be a pretty large task, so maybe we can break #5377 into multiple Issues so we can chip away at it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on issue #5816: Ansible roles: Traffic Ops no longer serves static files

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #5816:
URL: https://github.com/apache/trafficcontrol/issues/5816#issuecomment-833102879


   > Since a blanket webserver is not part of the stock ATC project
   
   That shouldn't be an issue if we document the need to set one up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jhowar201 commented on issue #5816: Ansible roles: Traffic Ops no longer serves static files

Posted by GitBox <gi...@apache.org>.
jhowar201 commented on issue #5816:
URL: https://github.com/apache/trafficcontrol/issues/5816#issuecomment-840810719


   Should the TO API endpoint also be updated to a valid version?
   * https://github.com/apache/trafficcontrol/blob/eed246c7854f6f9aefab4b65ce6c35846460e8c9/infrastructure/ansible/roles/dataset_loader/defaults/main.yml#L25


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jhg03a commented on issue #5816: Ansible roles: Traffic Ops no longer serves static files

Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #5816:
URL: https://github.com/apache/trafficcontrol/issues/5816#issuecomment-833101495


   Since a blanket webserver is not part of the stock ATC project, there's not a better alternative.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jhg03a commented on issue #5816: Ansible roles: Traffic Ops no longer serves static files

Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #5816:
URL: https://github.com/apache/trafficcontrol/issues/5816#issuecomment-841341552


   The only update that's actually necessary is that the variable default TO_URL should be swapped to localhost to conform with  other fields that have no appropriate default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jhg03a closed issue #5816: Ansible roles: Traffic Ops no longer serves static files

Posted by GitBox <gi...@apache.org>.
jhg03a closed issue #5816:
URL: https://github.com/apache/trafficcontrol/issues/5816


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org