You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/15 09:45:17 UTC
[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #16617: [improve] [txn] [PIP-160] Protocol changes and configuration changes for transaction batch log
liangyepianzhou commented on code in PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#discussion_r921993382
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2653,6 +2653,67 @@ public class ServiceConfiguration implements PulsarConfiguration {
)
private long transactionPendingAckLogIndexMinLag = 500L;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched"
+ + " record and persist into a single BK entry. This will make Pulsar transactions work more"
+ + " efficiently, aka batched log. see: https://github.com/apache/pulsar/issues/15370. Default false"
+ )
+ private boolean transactionLogBatchedWriteEnabled = false;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum log records count"
+ + " in a batch, default 512."
+ )
+ private int transactionLogBatchedWriteMaxRecords = 512;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means bytes size in a"
+ + " batch, default 4m."
+ )
+ private int transactionLogBatchedWriteMaxSize = 1024 * 1024 * 4;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum wait time(in millis)"
+ + " for the first record in a batch, default 1."
Review Comment:
```suggestion
+ " for the first record in a batch, default 1 millisecond."
```
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2653,6 +2653,67 @@ public class ServiceConfiguration implements PulsarConfiguration {
)
private long transactionPendingAckLogIndexMinLag = 500L;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched"
+ + " record and persist into a single BK entry. This will make Pulsar transactions work more"
+ + " efficiently, aka batched log. see: https://github.com/apache/pulsar/issues/15370. Default false"
+ )
+ private boolean transactionLogBatchedWriteEnabled = false;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum log records count"
+ + " in a batch, default 512."
+ )
+ private int transactionLogBatchedWriteMaxRecords = 512;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means bytes size in a"
+ + " batch, default 4m."
+ )
+ private int transactionLogBatchedWriteMaxSize = 1024 * 1024 * 4;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum wait time(in millis)"
+ + " for the first record in a batch, default 1."
+ )
+ private int transactionLogBatchedWriteMaxDelayInMillis = 1;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "Provide a mechanism allowing the transaction pending ack Log Store to aggregate multiple records"
+ + " into a batched record and persist into a single BK entry. This will make Pulsar transactions"
+ + " work more efficiently, aka batched log. see: https://github.com/apache/pulsar/issues/15370."
+ + " Default false."
+ )
+ private boolean transactionPendingAckBatchedWriteEnabled = false;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum log records count"
+ + " in a batch, default 512."
+ )
+ private int transactionPendingAckBatchedWriteMaxRecords = 512;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction pending ack log batch, this attribute means bytes size in"
+ + " a batch, default 4m."
+ )
+ private int transactionPendingAckBatchedWriteMaxSize = 1024 * 1024 * 4;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction pending ack log batch, this attribute means maximum wait"
+ + " time(in millis) for the first record in a batch, default 1."
Review Comment:
```suggestion
+ " time(in millisecond) for the first record in a batch, default 1 millisecond."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org