You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Grant Ingersoll (JIRA)" <ji...@apache.org> on 2008/02/24 17:01:14 UTC
[jira] Created: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
--------------------------------------------------------------------------------------------------------
Key: SOLR-485
URL: https://issues.apache.org/jira/browse/SOLR-485
Project: Solr
Issue Type: Improvement
Reporter: Grant Ingersoll
Priority: Minor
The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll resolved SOLR-485.
----------------------------------
Resolution: Won't Fix
See SOLR-572 for a better Spell checker
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595973#action_12595973 ]
Shalin Shekhar Mangar commented on SOLR-485:
--------------------------------------------
Otis - I was being careful not to break compatibility with current clients but I also think it makes sense to implement this as a Search Component from the ground up. Existing clients can continue to use SCRH and new clients can use the search component. That way, we can provide all the latest and greatest features without resorting to unintuitive syntax that may be needed to remain backwards-compatible.
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613982#action_12613982 ]
Grant Ingersoll commented on SOLR-485:
--------------------------------------
I think maybe we should just deprecate it for 1.3, but not make any other changes.
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595975#action_12595975 ]
Otis Gospodnetic commented on SOLR-485:
---------------------------------------
Sounds good and clean to me.
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614010#action_12614010 ]
Ryan McKinley commented on SOLR-485:
------------------------------------
I think we should deprecate it and remove it from the example solrconfig.xml
come to think of it we should remove all the deprecated handlers from solrconfig.xml. Dismax is really just a SearchHandler with a queryParser=dismax.
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572890#action_12572890 ]
Grant Ingersoll commented on SOLR-485:
--------------------------------------
I suppose that depends on whether you think people should still use the existing one. My take is it should be, since it doesn't analyze the tokens, thus things like case, etc. and it can't even take in multiword queries, which would be pretty common. Essentially, it really forces you to do things on the client side that shouldn't need to be done.
Ideally, the new version is a search component, such that one doesn't have to send separate requests, either.
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595884#action_12595884 ]
Shalin Shekhar Mangar commented on SOLR-485:
--------------------------------------------
Otis -- I'm working on the changes I described in SOLR-507, do you think those changes are better suited for a new RequestHandler? I was adding new request parameters to use the field's query analyzer as described in this issue.
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595964#action_12595964 ]
Otis Gospodnetic commented on SOLR-485:
---------------------------------------
Shalin - great! I *think* at this point it makes sense to (re)write the SCRH as a Search Component, so perhaps it's okay to take the deprecation route Grant proposed if the changes you are making look like they could break things for consumers of current SCRH.
Oh, do you know when, roughly, you will have this ready? Not trying to be pushy, but plan to see if/when I should make my SC changes. I'd rather wait for you a little instead of doing similar work in parallel.
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572829#action_12572829 ]
Otis Gospodnetic commented on SOLR-485:
---------------------------------------
Is the deprecation truly necessary here?
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613950#action_12613950 ]
Ryan McKinley commented on SOLR-485:
------------------------------------
Is the concern here not to break compatibility for folks who use are using the /trunk SCRH?
Before releasing 1.3, we _could_ consider reverting SCRH to the 1.2 version -- this way we have less code to maintain. As we move forward, are new features added to both?
(I'm fine keeping it in... just want to make sure we consider it before 1.3 release)
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll updated SOLR-485:
---------------------------------
Affects Version/s: 1.2
Fix Version/s: 1.3
Assignee: Grant Ingersoll
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572935#action_12572935 ]
Otis Gospodnetic commented on SOLR-485:
---------------------------------------
I understand it's different under the hood, just wondering if it would really break things for existing users. If not, perhaps a replacement is enough. No big deal.
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595867#action_12595867 ]
Otis Gospodnetic commented on SOLR-485:
---------------------------------------
I'm about to make some SCRH changes (e.g. read words from one or more files instead of from another index's field, optionally strip diacritics...) and I'm wondering where you are with this, Grant. I'll work off of trunk unless you have something you can attach here.
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-485) Deprecate SpellCheckRequestHandler
replace with one that does query analysis and spell checks each token
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620236#action_12620236 ]
Grant Ingersoll commented on SOLR-485:
--------------------------------------
I'm going to mark as deprecated.
> Deprecate SpellCheckRequestHandler replace with one that does query analysis and spell checks each token
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-485
> URL: https://issues.apache.org/jira/browse/SOLR-485
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.3
>
>
> The current spellchecker does not handle multiword queries very well, if at all. Depending on the settings, it either ignores multiword tokens, or it splits on whitespace. It should use the query analyzer associated with the spelling field to produce tokens for spelling.
> We should deprecate the current one and replace it with one that is similar, but does the appropriate thing with the query tokens.
> Seehttp://www.mail-archive.com/solr-dev@lucene.apache.org/msg07542.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.