[jira] [Updated] (HBASE-15803) ZooKeeperWatcher's constructor can leak a ZooKeeper instance with throwing ZooKeeperConnectionException when canCreateBaseZNode is true

["Ted Yu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-15803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-15803:
---------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 1.4.0
                   2.0.0
           Status: Resolved  (was: Patch Available)

Thanks for the review, Hiroshi.

> ZooKeeperWatcher's constructor can leak a ZooKeeper instance with throwing ZooKeeperConnectionException when canCreateBaseZNode is true
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15803
>                 URL: https://issues.apache.org/jira/browse/HBASE-15803
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Hiroshi Ikeda
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: 15803.v1.txt, 15803.v2.txt
>
>
> {code}
>   public ZooKeeperWatcher(Configuration conf, String identifier,
>       Abortable abortable, boolean canCreateBaseZNode)
>   throws IOException, ZooKeeperConnectionException {
> ...skip...
>     this.recoverableZooKeeper = ZKUtil.connect(...
> ...skip...
>     if (canCreateBaseZNode) {
>       createBaseZNodes();
>     }
>   }
>   private void createBaseZNodes() throws ZooKeeperConnectionException {
> {code}
> The registered watcher doesn't seem to close the Zookeeper instance by watch events, and the instance keeps alive when createBaseZNodes is failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)