You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/09 04:31:54 UTC

[GitHub] [incubator-nuttx] anchao opened a new pull request #2260: eventfd: remove the unique minor limit

anchao opened a new pull request #2260:
URL: https://github.com/apache/incubator-nuttx/pull/2260


   ## Summary
   
   eventfd: remove the unique minor limit
   
   ## Impact
   
   The unique minor limit of 255 will overflow easily in
   some scenarios where eventfd needs to be create/destroy
   frequently:
   
   ```
     while (1)
       {
         fd = eventfd(0, 0);  // minor++
         sleep(1);
         close(fd);
       }
   ```
   
   remove the unique minor limit.
   
   Change-Id: I0ea1c825ce9b542c883166cb3e72574455ffdd0d
   Signed-off-by: chao.an <an...@xiaomi.com>
   
   ## Testing
   
   eventfd create/destroy test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #2260: eventfd: remove the unique minor limit

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2260:
URL: https://github.com/apache/incubator-nuttx/pull/2260#issuecomment-723972606


   Ok, the modification is correct, but it should better to use "size_t" instead uint32_t because it will use less memory on arch with CONFIG_SMALL_MEMORY. Please see include/sys/types.h as reference.
   NuttX needs to run on MCUs with 8-bit, 16-bit, 32-bit, etc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2260: eventfd: remove the unique minor limit

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2260:
URL: https://github.com/apache/incubator-nuttx/pull/2260


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2260: eventfd: remove the unique minor limit

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2260:
URL: https://github.com/apache/incubator-nuttx/pull/2260#issuecomment-725138126


   @acassis is the patch good to merge now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org