[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2698: [GOBBLIN-840] avoid creating a flow execution id by both master and slave gaas

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2698: [GOBBLIN-840] avoid creating a flow execution id by both master and slave gaas
URL: https://github.com/apache/incubator-gobblin/pull/2698#discussion_r309522490
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/restli/GobblinServiceFlowConfigResourceHandler.java
 ##########
 @@ -96,6 +97,12 @@ public CreateResponse createFlowConfig(FlowConfig flowConfig)
     String flowName = flowConfig.getId().getFlowName();
     String flowGroup = flowConfig.getId().getFlowGroup();
 
+    if (flowConfig.getProperties().containsKey(ConfigurationKeys.FLOW_EXECUTION_ID_KEY)) {
 
 Review comment:
   Will this be executed only in master mode? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services