You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by va...@apache.org on 2006/12/09 09:33:54 UTC
svn commit: r484948 - in /geronimo/specs:
branches/1_0/geronimo-spec-j2ee-connector/src/java/javax/resource/
branches/1_0/geronimo-spec-j2ee-connector/src/test/javax/resource/
branches/1_1/geronimo-spec-j2ee-connector/src/main/java/javax/resource/
bran...
Author: vamsic007
Date: Sat Dec 9 00:33:52 2006
New Revision: 484948
URL: http://svn.apache.org/viewvc?view=rev&rev=484948
Log:
GERONIMO-1519 ResourceException.toString() can return null
o The method seems to have been introduced to account for a bad testcase. Removed ResourceException.toString() and the corresponding test ResourceExceptionTest.testToString()
o For a discussion on this, see http://www.mail-archive.com/dev%40geronimo.apache.org/msg38005.html
Modified:
geronimo/specs/branches/1_0/geronimo-spec-j2ee-connector/src/java/javax/resource/ResourceException.java
geronimo/specs/branches/1_0/geronimo-spec-j2ee-connector/src/test/javax/resource/ResourceExceptionTest.java
geronimo/specs/branches/1_1/geronimo-spec-j2ee-connector/src/main/java/javax/resource/ResourceException.java
geronimo/specs/branches/1_1/geronimo-spec-j2ee-connector/src/test/java/javax/resource/ResourceExceptionTest.java
geronimo/specs/trunk/geronimo-j2ee-connector_1.5_spec/src/main/java/javax/resource/ResourceException.java
geronimo/specs/trunk/geronimo-j2ee-connector_1.5_spec/src/test/java/javax/resource/ResourceExceptionTest.java
Modified: geronimo/specs/branches/1_0/geronimo-spec-j2ee-connector/src/java/javax/resource/ResourceException.java
URL: http://svn.apache.org/viewvc/geronimo/specs/branches/1_0/geronimo-spec-j2ee-connector/src/java/javax/resource/ResourceException.java?view=diff&rev=484948&r1=484947&r2=484948
==============================================================================
--- geronimo/specs/branches/1_0/geronimo-spec-j2ee-connector/src/java/javax/resource/ResourceException.java (original)
+++ geronimo/specs/branches/1_0/geronimo-spec-j2ee-connector/src/java/javax/resource/ResourceException.java Sat Dec 9 00:33:52 2006
@@ -76,9 +76,4 @@
// unit tests revealed that Throwable.initCause is not invoked
this.linkedException = ex;
}
-
- public String toString() {
- // unit tests revealed that the errorCode is not included
- return getMessage();
- }
}
Modified: geronimo/specs/branches/1_0/geronimo-spec-j2ee-connector/src/test/javax/resource/ResourceExceptionTest.java
URL: http://svn.apache.org/viewvc/geronimo/specs/branches/1_0/geronimo-spec-j2ee-connector/src/test/javax/resource/ResourceExceptionTest.java?view=diff&rev=484948&r1=484947&r2=484948
==============================================================================
--- geronimo/specs/branches/1_0/geronimo-spec-j2ee-connector/src/test/javax/resource/ResourceExceptionTest.java (original)
+++ geronimo/specs/branches/1_0/geronimo-spec-j2ee-connector/src/test/javax/resource/ResourceExceptionTest.java Sat Dec 9 00:33:52 2006
@@ -51,12 +51,4 @@
exception.setLinkedException(root);
assertSame(root, exception.getLinkedException());
}
-
- public void testToString() {
- ResourceException exception = new ResourceException("problem");
- assertEquals("problem", exception.toString());
-
- ResourceException other = new ResourceException("other problem", "123");
- assertEquals("other problem", other.toString());
- }
}
Modified: geronimo/specs/branches/1_1/geronimo-spec-j2ee-connector/src/main/java/javax/resource/ResourceException.java
URL: http://svn.apache.org/viewvc/geronimo/specs/branches/1_1/geronimo-spec-j2ee-connector/src/main/java/javax/resource/ResourceException.java?view=diff&rev=484948&r1=484947&r2=484948
==============================================================================
--- geronimo/specs/branches/1_1/geronimo-spec-j2ee-connector/src/main/java/javax/resource/ResourceException.java (original)
+++ geronimo/specs/branches/1_1/geronimo-spec-j2ee-connector/src/main/java/javax/resource/ResourceException.java Sat Dec 9 00:33:52 2006
@@ -76,11 +76,4 @@
// unit tests revealed that Throwable.initCause is not invoked
this.linkedException = ex;
}
-
- public String toString() {
- // unit tests revealed that the errorCode is not included
- String className = getClass().getName();
- String msg = getMessage();
- return msg != null ? className + ": "+msg : className;
- }
}
Modified: geronimo/specs/branches/1_1/geronimo-spec-j2ee-connector/src/test/java/javax/resource/ResourceExceptionTest.java
URL: http://svn.apache.org/viewvc/geronimo/specs/branches/1_1/geronimo-spec-j2ee-connector/src/test/java/javax/resource/ResourceExceptionTest.java?view=diff&rev=484948&r1=484947&r2=484948
==============================================================================
--- geronimo/specs/branches/1_1/geronimo-spec-j2ee-connector/src/test/java/javax/resource/ResourceExceptionTest.java (original)
+++ geronimo/specs/branches/1_1/geronimo-spec-j2ee-connector/src/test/java/javax/resource/ResourceExceptionTest.java Sat Dec 9 00:33:52 2006
@@ -51,12 +51,4 @@
exception.setLinkedException(root);
assertSame(root, exception.getLinkedException());
}
-
- public void testToString() {
- ResourceException exception = new ResourceException("problem");
- assertEquals(ResourceException.class.getName()+": "+"problem", exception.toString());
-
- ResourceException other = new ResourceException("other problem", "123");
- assertEquals(ResourceException.class.getName()+": "+"other problem", other.toString());
- }
}
Modified: geronimo/specs/trunk/geronimo-j2ee-connector_1.5_spec/src/main/java/javax/resource/ResourceException.java
URL: http://svn.apache.org/viewvc/geronimo/specs/trunk/geronimo-j2ee-connector_1.5_spec/src/main/java/javax/resource/ResourceException.java?view=diff&rev=484948&r1=484947&r2=484948
==============================================================================
--- geronimo/specs/trunk/geronimo-j2ee-connector_1.5_spec/src/main/java/javax/resource/ResourceException.java (original)
+++ geronimo/specs/trunk/geronimo-j2ee-connector_1.5_spec/src/main/java/javax/resource/ResourceException.java Sat Dec 9 00:33:52 2006
@@ -75,11 +75,4 @@
// unit tests revealed that Throwable.initCause is not invoked
this.linkedException = ex;
}
-
- public String toString() {
- // unit tests revealed that the errorCode is not included
- String className = getClass().getName();
- String msg = getMessage();
- return msg != null ? className + ": "+msg : className;
- }
}
Modified: geronimo/specs/trunk/geronimo-j2ee-connector_1.5_spec/src/test/java/javax/resource/ResourceExceptionTest.java
URL: http://svn.apache.org/viewvc/geronimo/specs/trunk/geronimo-j2ee-connector_1.5_spec/src/test/java/javax/resource/ResourceExceptionTest.java?view=diff&rev=484948&r1=484947&r2=484948
==============================================================================
--- geronimo/specs/trunk/geronimo-j2ee-connector_1.5_spec/src/test/java/javax/resource/ResourceExceptionTest.java (original)
+++ geronimo/specs/trunk/geronimo-j2ee-connector_1.5_spec/src/test/java/javax/resource/ResourceExceptionTest.java Sat Dec 9 00:33:52 2006
@@ -50,12 +50,4 @@
exception.setLinkedException(root);
assertSame(root, exception.getLinkedException());
}
-
- public void testToString() {
- ResourceException exception = new ResourceException("problem");
- assertEquals(ResourceException.class.getName()+": "+"problem", exception.toString());
-
- ResourceException other = new ResourceException("other problem", "123");
- assertEquals(ResourceException.class.getName()+": "+"other problem", other.toString());
- }
}