You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/27 15:59:02 UTC
[GitHub] [spark] MaxGekk opened a new pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
MaxGekk opened a new pull request #29884:
URL: https://github.com/apache/spark/pull/29884
### What changes were proposed in this pull request?
Convert the `ROWID` type in the Oracle JDBC dialect to Catalyst's `StringType`. The doc for Oracle 19c says explicitly that the type must be string: https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/Data-Types.html#GUID-AEF1FE4C-2DE5-4BE7-BB53-83AD8F1E34EF
### Why are the changes needed?
To avoid the exception showed in https://stackoverflow.com/questions/52244492/spark-jdbc-dataframereader-fails-to-read-oracle-table-with-datatype-as-rowid
### Does this PR introduce _any_ user-facing change?
Yes
### How was this patch tested?
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-699661380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-701902837
Thanks! Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-700895481
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-701886985
Anything else can I do in this PR to be merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-701918650
Thank you, @MaxGekk and all!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-699661380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-700349243
Yeah, seems fine too. But I agree with adding a test at `OracleIntegrationSuite` which already exists.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-700834844
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33860/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-700895481
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-700784421
**[Test build #129243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129243/testReport)** for PR 29884 at commit [`9b3a875`](https://github.com/apache/spark/commit/9b3a875e229a0a83f6c2a40b87a69bd0cb67a280).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-699684258
**[Test build #129153 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129153/testReport)** for PR 29884 at commit [`40aa962`](https://github.com/apache/spark/commit/40aa962997996309d365940ff8617db4ef0e32a9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #29884:
URL: https://github.com/apache/spark/pull/29884
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-699661367
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33768/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-700834874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-700834874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-699654004
**[Test build #129153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129153/testReport)** for PR 29884 at commit [`40aa962`](https://github.com/apache/spark/commit/40aa962997996309d365940ff8617db4ef0e32a9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-699684464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-699659173
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33768/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-700907391
@srowen @maropu @HyukjinKwon I added a test to `OracleIntegrationSuite`. Please, take a look at this PR one more time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-700784421
**[Test build #129243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129243/testReport)** for PR 29884 at commit [`9b3a875`](https://github.com/apache/spark/commit/9b3a875e229a0a83f6c2a40b87a69bd0cb67a280).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-699654004
**[Test build #129153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129153/testReport)** for PR 29884 at commit [`40aa962`](https://github.com/apache/spark/commit/40aa962997996309d365940ff8617db4ef0e32a9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-701901740
Looks okay and I'll merge it. If more comments from the other two reviewers, please fix them in folowup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-700894469
**[Test build #129243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129243/testReport)** for PR 29884 at commit [`9b3a875`](https://github.com/apache/spark/commit/9b3a875e229a0a83f6c2a40b87a69bd0cb67a280).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` assert(types(0).equals(\"class java.lang.String\"))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-700816406
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33860/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-699684464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29884:
URL: https://github.com/apache/spark/pull/29884#issuecomment-699809729
Could you add tests in the Oracle integration test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org