You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2018/10/16 22:33:59 UTC

[GitHub] guacamole-client pull request #335: GUACAMOLE-524: Correct handling of param...

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/guacamole-client/pull/335

    GUACAMOLE-524: Correct handling of parameter tokens within SimpleConnection

    The changes introduced by #333 do not correctly apply parameter tokens within `SimplyConnection`. The created `TokenFilter` is never assigned any tokens and is ultimately applied to the wrong `GuacamoleConfiguration`.
    
    These changes correct all that.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/guacamole-client correct-simpleconnection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-client/pull/335.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #335
    
----
commit 333a8c411f90f847f50111939089f3d10610ed89
Author: Michael Jumper <mj...@...>
Date:   2018-10-16T20:21:57Z

    GUACAMOLE-524: Provide convenience constructor for TokenFilter which initializes the filter with provided tokens.

commit 143c10b6efb42a6bccd95714795d0c6ab0a06be1
Author: Michael Jumper <mj...@...>
Date:   2018-10-16T20:23:55Z

    GUACAMOLE-524: Correct handling of tokens within SimpleConnection. The copy of the configuration should be filtered, not the original, and token values need to actually be set.

----


---

[GitHub] guacamole-client pull request #335: GUACAMOLE-524: Correct handling of param...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/guacamole-client/pull/335


---