[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4551: Cleanup volume information from db when deleted

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4551:
URL: https://github.com/apache/cloudstack/pull/4551#discussion_r603954401



##########
File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
##########
@@ -392,15 +405,16 @@ protected Answer copyVolumeBetweenPools(DataObject srcData, DataObject destData)
                     return answer;
                 }
             } catch (Exception e) {
-                if (imageStore.exists(objOnImageStore)) {
+                if (objOnImageStore != null) {

Review comment:
       is not null enough? what if it is an object but doesn't exist? or it does but not on `imageStore`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org