You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2019/05/17 10:00:55 UTC
Review Request 70652: RANGER-2435:Add support for sticky breadcrumbs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70652/
-----------------------------------------------------------
Review request for ranger, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGEr-2345
https://issues.apache.org/jira/browse/RANGEr-2345
Repository: ranger
Description
-------
The breadcrumb for Security zone name on policy creation/policy edit page should be stagnant, and remain visible to user even if the page is scrolled up/down.
Currently, the security zone name goes out of view once the page is scrolled down.
This can be inconvenient to user who may want to check the zone under which he is editing the policy.
Added support for the same throught the application.
Diffs
-----
security-admin/src/main/webapp/index.html 59eb9cf
security-admin/src/main/webapp/styles/xa.css 6ae646d
Diff: https://reviews.apache.org/r/70652/diff/1/
Testing
-------
Tested on every page:
1. Service create/edit page
2. Policy create/edit page - Zoned and unzoned
3. Tag Based policy create/edit page-zoned/unzoned
4. Security Zone view/create/edit page
5. Users/Group create/edit page
6. KMS service/policies page
7. Reports Tab
8. Permission Page.
Thanks,
Nitin Galave
Re: Review Request 70652: RANGER-2435:Add support for sticky
breadcrumbs.
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70652/#review215343
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On May 17, 2019, 10 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70652/
> -----------------------------------------------------------
>
> (Updated May 17, 2019, 10 a.m.)
>
>
> Review request for ranger, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGEr-2345
> https://issues.apache.org/jira/browse/RANGEr-2345
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The breadcrumb for Security zone name on policy creation/policy edit page should be stagnant, and remain visible to user even if the page is scrolled up/down.
> Currently, the security zone name goes out of view once the page is scrolled down.
> This can be inconvenient to user who may want to check the zone under which he is editing the policy.
>
> Added support for the same throught the application.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/index.html 59eb9cf
> security-admin/src/main/webapp/styles/xa.css 6ae646d
>
>
> Diff: https://reviews.apache.org/r/70652/diff/1/
>
>
> Testing
> -------
>
> Tested on every page:
> 1. Service create/edit page
> 2. Policy create/edit page - Zoned and unzoned
> 3. Tag Based policy create/edit page-zoned/unzoned
> 4. Security Zone view/create/edit page
> 5. Users/Group create/edit page
> 6. KMS service/policies page
> 7. Reports Tab
> 8. Permission Page.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 70652: RANGER-2435:Add support for sticky
breadcrumbs.
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70652/#review215358
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On May 17, 2019, 10 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70652/
> -----------------------------------------------------------
>
> (Updated May 17, 2019, 10 a.m.)
>
>
> Review request for ranger, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGEr-2345
> https://issues.apache.org/jira/browse/RANGEr-2345
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The breadcrumb for Security zone name on policy creation/policy edit page should be stagnant, and remain visible to user even if the page is scrolled up/down.
> Currently, the security zone name goes out of view once the page is scrolled down.
> This can be inconvenient to user who may want to check the zone under which he is editing the policy.
>
> Added support for the same throught the application.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/index.html 59eb9cf
> security-admin/src/main/webapp/styles/xa.css 6ae646d
>
>
> Diff: https://reviews.apache.org/r/70652/diff/1/
>
>
> Testing
> -------
>
> Tested on every page:
> 1. Service create/edit page
> 2. Policy create/edit page - Zoned and unzoned
> 3. Tag Based policy create/edit page-zoned/unzoned
> 4. Security Zone view/create/edit page
> 5. Users/Group create/edit page
> 6. KMS service/policies page
> 7. Reports Tab
> 8. Permission Page.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 70652: RANGER-2435:Add support for sticky
breadcrumbs.
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70652/
-----------------------------------------------------------
(Updated May 20, 2019, 12:47 p.m.)
Review request for ranger, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGEr-2435
https://issues.apache.org/jira/browse/RANGEr-2435
Repository: ranger
Description
-------
The breadcrumb for Security zone name on policy creation/policy edit page should be stagnant, and remain visible to user even if the page is scrolled up/down.
Currently, the security zone name goes out of view once the page is scrolled down.
This can be inconvenient to user who may want to check the zone under which he is editing the policy.
Added support for the same throught the application.
Diffs
-----
security-admin/src/main/webapp/index.html 59eb9cf
security-admin/src/main/webapp/styles/xa.css 6ae646d
Diff: https://reviews.apache.org/r/70652/diff/1/
Testing
-------
Tested on every page:
1. Service create/edit page
2. Policy create/edit page - Zoned and unzoned
3. Tag Based policy create/edit page-zoned/unzoned
4. Security Zone view/create/edit page
5. Users/Group create/edit page
6. KMS service/policies page
7. Reports Tab
8. Permission Page.
Thanks,
Nitin Galave