You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "zhuanshenbsj1 (via GitHub)" <gi...@apache.org> on 2023/04/07 00:15:48 UTC

[GitHub] [hudi] zhuanshenbsj1 commented on a diff in pull request #8394: adjust HoodieTableSink for clean

zhuanshenbsj1 commented on code in PR #8394:
URL: https://github.com/apache/hudi/pull/8394#discussion_r1160347951


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSink.java:
##########
@@ -103,6 +103,8 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
           conf.setBoolean(FlinkOptions.COMPACTION_ASYNC_ENABLED, false);
         }
         return Pipelines.compact(conf, pipeline);
+      } else if (OptionsResolver.isMorTable(conf)) {
+        return Pipelines.dummySink(pipeline);
       } else {

Review Comment:
       Offline compaction do clean,Consistent with clustering.
     
       // Append mode
         if (OptionsResolver.isAppendMode(conf)) {
           DataStream<Object> pipeline = Pipelines.append(conf, rowType, dataStream, context.isBounded());
           if (OptionsResolver.needsAsyncClustering(conf)) {
             return Pipelines.cluster(conf, rowType, pipeline);
           } else {
             return Pipelines.dummySink(pipeline);// If execute-clustering=true, no clean.
           }
         }



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org