You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "jyothsnakonisa (via GitHub)" <gi...@apache.org> on 2026/04/09 19:53:26 UTC
[PR] CASSANALYTICS-149 Change log level for logs in CassandraSchema to debug level to avoid log spamming [cassandra-analytics]
jyothsnakonisa opened a new pull request, #196:
URL: https://github.com/apache/cassandra-analytics/pull/196
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-149 Change log level for logs in CassandraSchema to debug level to avoid log spamming [cassandra-analytics]
Posted by "jyothsnakonisa (via GitHub)" <gi...@apache.org>.
jyothsnakonisa commented on PR #196:
URL: https://github.com/apache/cassandra-analytics/pull/196#issuecomment-4217884974
CircleCI: https://app.circleci.com/pipelines/gh/jyothsnakonisa/cassandra-analytics/76/workflows/764d972f-8f81-4b63-8dd9-3f417daff877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-149 Change log level for logs in CassandraSchema to debug level to avoid log spamming [cassandra-analytics]
Posted by "yifan-c (via GitHub)" <gi...@apache.org>.
yifan-c commented on code in PR #196:
URL: https://github.com/apache/cassandra-analytics/pull/196#discussion_r3061021817
##########
cassandra-four-zero-types/src/main/java/org/apache/cassandra/bridge/CassandraSchema.java:
##########
@@ -288,10 +288,14 @@ public static void updateCdcSchema(@NotNull Schema schema,
@NotNull Partitioner partitioner,
@NotNull TableIdLookup tableIdLookup)
{
- LOGGER.info("Updating CDC schema tables='{}'",
+ if (LOGGER.isDebugEnabled())
+ {
+ LOGGER.debug("Updating CDC schema tables='{}'",
cdcTables.stream()
- .map(t -> String.format("%s.%s", t.keyspace(), t.table()))
- .collect(Collectors.joining(",")));
+ .map(t -> String.format("%s.%s", t.keyspace(), t.table()))
+ .collect(Collectors.joining(",")));
Review Comment:
lines are not aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-149 Change log level for logs in CassandraSchema to debug level to avoid log spamming [cassandra-analytics]
Posted by "jyothsnakonisa (via GitHub)" <gi...@apache.org>.
jyothsnakonisa commented on code in PR #196:
URL: https://github.com/apache/cassandra-analytics/pull/196#discussion_r3066605135
##########
cassandra-four-zero-types/src/main/java/org/apache/cassandra/bridge/CassandraSchema.java:
##########
@@ -288,10 +288,14 @@ public static void updateCdcSchema(@NotNull Schema schema,
@NotNull Partitioner partitioner,
@NotNull TableIdLookup tableIdLookup)
{
- LOGGER.info("Updating CDC schema tables='{}'",
+ if (LOGGER.isDebugEnabled())
Review Comment:
Yifan flagged that we do this following computation in the log. Even if debug logging is not enabled it gets computed if we don't have the check. This is an performance optimization
```
cdcTables.stream()
.map(t -> String.format("%s.%s", t.keyspace(), t.table()))
.collect(Collectors.joining(","))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-149 Change log level for logs in CassandraSchema to debug level to avoid log spamming [cassandra-analytics]
Posted by "skoppu22 (via GitHub)" <gi...@apache.org>.
skoppu22 commented on code in PR #196:
URL: https://github.com/apache/cassandra-analytics/pull/196#discussion_r3065560965
##########
cassandra-four-zero-types/src/main/java/org/apache/cassandra/bridge/CassandraSchema.java:
##########
@@ -288,10 +288,14 @@ public static void updateCdcSchema(@NotNull Schema schema,
@NotNull Partitioner partitioner,
@NotNull TableIdLookup tableIdLookup)
{
- LOGGER.info("Updating CDC schema tables='{}'",
+ if (LOGGER.isDebugEnabled())
Review Comment:
Do we need explicit isDebugEnabled check? I believe LOGGER.debug work only when debug enabled right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-149 Change log level for logs in CassandraSchema to debug level to avoid log spamming [cassandra-analytics]
Posted by "jyothsnakonisa (via GitHub)" <gi...@apache.org>.
jyothsnakonisa merged PR #196:
URL: https://github.com/apache/cassandra-analytics/pull/196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org