You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/11/07 09:27:16 UTC

Review Request 40046: Include SSL related environment variables.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40046/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.


Bugs: MESOS-3815
    https://issues.apache.org/jira/browse/MESOS-3815


Repository: mesos


Description
-------

Include SSL related environment variables.


Diffs
-----

  src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b 

Diff: https://reviews.apache.org/r/40046/diff/


Testing
-------


Thanks,

haosdent huang

Re: Review Request 40046: Include SSL related environment variables.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40046/#review105580
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40046]

All tests passed.

- Mesos ReviewBot


On Nov. 7, 2015, 9:28 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40046/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2015, 9:28 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3815
>     https://issues.apache.org/jira/browse/MESOS-3815
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Include SSL related environment variables.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b 
> 
> Diff: https://reviews.apache.org/r/40046/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40046: Include SSL related environment variables.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40046/
-----------------------------------------------------------

(Updated Nov. 7, 2015, 9:28 a.m.)


Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.


Changes
-------

Rebase


Bugs: MESOS-3815
    https://issues.apache.org/jira/browse/MESOS-3815


Repository: mesos


Description
-------

Include SSL related environment variables.


Diffs (updated)
-----

  src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b 

Diff: https://reviews.apache.org/r/40046/diff/


Testing
-------


Thanks,

haosdent huang

Re: Review Request 40046: Include SSL related environment variables.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40046/#review105578
-----------------------------------------------------------


Bad patch!

Reviews applied: [40046]

Failed command: ./support/apply-review.sh -n -r 40046

Error:
 2015-11-07 09:03:59 URL:https://reviews.apache.org/r/40046/diff/raw/ [2854/2854] -> "40046.patch" [1]
error: patch failed: src/slave/containerizer/containerizer.cpp:256
error: src/slave/containerizer/containerizer.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 7, 2015, 8:27 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40046/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2015, 8:27 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3815
>     https://issues.apache.org/jira/browse/MESOS-3815
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Include SSL related environment variables.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b 
> 
> Diff: https://reviews.apache.org/r/40046/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>