You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2023/04/04 03:26:59 UTC

[GitHub] [incubator-uniffle] advancedxy opened a new issue, #793: [FEATURE] output prometheus metrics with custom cluster labels

advancedxy opened a new issue, #793:
URL: https://github.com/apache/incubator-uniffle/issues/793

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Describe the feature
   
   There might be multiple clusters due to capacity limit or idc spreading. For example, the rss clusters might be deployed on multiple IDCs to fulfill different business needs. Therefore it's a nature need to identify different rss clusters.
   
   Since there are multiple clusters, the metrics collected would be mixed together, I'd like to add the label of cluster name to the metrics produced by rss.
   
   ### Motivation
   
   For better monitoring.
   
   ### Describe the solution
   
   When the rss cluster start up, the cluster name env would be automatically injected(by rss operator) or configured by the administrator.
   
   Coordinator and shuffle server would detect the cluster name and append it to the metrics produced.,
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] advancedxy commented on issue #793: [FEATURE] output prometheus metrics with custom cluster labels

Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #793:
URL: https://github.com/apache/incubator-uniffle/issues/793#issuecomment-1498786166

   Closing this since pod name could contain cluster name info, there's no need to populate rss cluster name additionally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] advancedxy closed issue #793: [FEATURE] output prometheus metrics with custom cluster labels

Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy closed issue #793: [FEATURE] output prometheus metrics with custom cluster labels
URL: https://github.com/apache/incubator-uniffle/issues/793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org