You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2023/06/16 08:18:42 UTC
[GitHub] [camel] orpiske commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
orpiske commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1594299957
> The failure in the checkstyle job is interesting for two reasons:
>
> 1. `checkstyle:checkstyle` requires resolved dependencies and because it runs before any `install` and because `https://repository.apache.org/snapshots/` are enabled by default, `checkstyle:checkstyle` pulls snapshots. I'd say CI should be reproducible and therefore should not rely on any snapshots other than local ones built from the current commit.
>
> 2. Rather than fixing the above, I wonder whether we still need checkstyle at all? I used to be a fan of it back in times when formatter and impsort plugins did not exist. But since I know the two, I tend to hate checkstyle. It just complains and cannot fix even basic things. Would anybody veto removing checkstyle and enabling formatter and impsort plugins as a part of the default build? This would also reduce the amount of clutter in the git history.
The biggest problem with removing the `checkstyle` is for external contributions: committers and regular contributors usually know the style patterns that we have, but external contributors usually don't.
That said: the way `checkstyle` verification is working nowadays is not adequate IMHO. It fails a lot due to the issues you pointed.
So, I am 0 on this and I'd like to hear what others have to say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org