[GitHub] incubator-hawq pull request #954: [WIP] HAWQ-1091. Fix HAWQ InputFormat Bugs...

[ictmalili <gi...@git.apache.org>]

Github user ictmalili commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/954#discussion_r82523067
  
    --- Diff: contrib/hawq-hadoop/hawq-mapreduce-common/src/main/java/com/pivotal/hawq/mapreduce/metadata/MetadataYAMLAccessor.java ---
    @@ -198,6 +201,9 @@ private HAWQParquetTableMetadata extractParquetMetadata(HAWQDatabaseMetadata dbM
     			Map<?, ?> file = (Map<?, ?>) files.get(i);
     			final String filePath = file.get("path").toString();
     			final long fileLen = Long.parseLong(file.get("size").toString());
    +			if (fileLen == 0) {
    +			  throw new IllegalStateException("Could not new HAWQParquetFileStatus with a empty file.");
    +			}
    --- End diff --
    
    Could we change the error message to a more meaningful description.  For example, "Empty file $filePath, can not be processed by HAWQParquetInputFormat"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---