You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2021/02/20 12:59:45 UTC

[GitHub] [wicket] svenmeier opened a new pull request #463: WICKET-6868 ajax submit allow calling onsubmit on form

svenmeier opened a new pull request #463:
URL: https://github.com/apache/wicket/pull/463


   In Wicket 7.x a form's `onsubmit()` was called for multipart Ajax submits only. This made sense, since multipart requests were submitted with a hidden form.
   
   Since Wicket 8.x `onsubmit()` is no longer called, since a multipart Ajax submit is now performed like any other Ajax request. For consistency I would not want to go back to calling `onsubmit()` for multipart submits only.
   But we can't call `onsubmit()` for *all* Ajax submit either, as this would be a change to a much more frequent usage.
   
   Thus I propose to make this configurable with a new `AjaxFormSubmitBehavior#shouldCallJavaScriptOnsubmit()`, default would be `false`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [wicket] svenmeier closed pull request #463: WICKET-6868 ajax submit allow calling onsubmit on form

Posted by GitBox <gi...@apache.org>.
svenmeier closed pull request #463:
URL: https://github.com/apache/wicket/pull/463


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [wicket] svenmeier commented on pull request #463: WICKET-6868 ajax submit allow calling onsubmit on form

Posted by GitBox <gi...@apache.org>.
svenmeier commented on pull request #463:
URL: https://github.com/apache/wicket/pull/463#issuecomment-782731018


   I improved the solution, so all event 'submit' handlers are triggered.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [wicket] svenmeier commented on pull request #463: WICKET-6868 ajax submit allow calling onsubmit on form

Posted by GitBox <gi...@apache.org>.
svenmeier commented on pull request #463:
URL: https://github.com/apache/wicket/pull/463#issuecomment-786104889


   Merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org