You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Zakelly (via GitHub)" <gi...@apache.org> on 2024/05/24 15:32:13 UTC

[PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

Zakelly opened a new pull request, #24840:
URL: https://github.com/apache/flink/pull/24840

   ## What is the purpose of the change
   
   See FLINK-35446. It seems the file merging is disabled, thus the `FileMergingSnapshotManagerBase#initFileSystem` is never called. And at this time if we restore from a checkpoint that files are already merged, the managed path is needed while it has not been initialized. This PR fix this.
   
   ## Brief change log
   
    - Skip using managed directory to claim management of files if it is not initialized, which means the no management need to be claimed in this case.
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage. But some github actions may fail like FLINK-35446.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24840:
URL: https://github.com/apache/flink/pull/24840#issuecomment-2129877895

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a78e68711f02ccaeb069376270649229d8c53c8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5a78e68711f02ccaeb069376270649229d8c53c8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5a78e68711f02ccaeb069376270649229d8c53c8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on PR #24840:
URL: https://github.com/apache/flink/pull/24840#issuecomment-2129858482

   @fredia @ljz2051 Would you please take a look? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly closed pull request #24840: [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files
URL: https://github.com/apache/flink/pull/24840


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org