You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/05/10 03:46:33 UTC

[GitHub] [calcite] hbtoo commented on a change in pull request #1966: [CALCITE-3981] Volcano.register should not return stale/merged subset

hbtoo commented on a change in pull request #1966:
URL: https://github.com/apache/calcite/pull/1966#discussion_r422579520



##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -579,6 +579,7 @@ public RelSubset register(
           "equivRel rowtype",
           equivRel.getRowType(),
           Litmus.THROW);
+      equivRel = ensureRegistered(equivRel, null);

Review comment:
       It usually is, but I believe it is not specifically written as required in the api. I think it is safer to add this line just in case some rule feed in an equivalent which is also not yet registered. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org