[GitHub] [iceberg] rdblue commented on a diff in pull request #4826: Nessie: Use unique path for different table with same name

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4826:
URL: https://github.com/apache/iceberg/pull/4826#discussion_r928324992


##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieTable.java:
##########
@@ -400,7 +405,7 @@ private void validateRegister(TableIdentifier identifier, String metadataVersion
 
   @Test
   public void testRegisterTableWithGivenBranch() {
-    List<String> metadataVersionFiles = metadataVersionFiles(TABLE_NAME);
+    List<String> metadataVersionFiles = metadataVersionFiles(tableNameWithUUID(catalog.loadTable(TABLE_IDENTIFIER)));

Review Comment:
   It seems odd to use the location to get a directory name, but then add the rest of the location back to list files. Why not just update `metadataVersionFiles` and `manifestFiles` to accept a full path?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org