You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ozone.apache.org by ms...@apache.org on 2022/04/13 13:49:23 UTC
[ozone] branch master updated: HDDS-6579. Add commandline argument for Container Info command. (#3306)
This is an automated email from the ASF dual-hosted git repository.
msingh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 141ced1196 HDDS-6579. Add commandline argument for Container Info command. (#3306)
141ced1196 is described below
commit 141ced1196d42330026148036e85f32317e011a4
Author: Mukul Kumar Singh <mk...@gmail.com>
AuthorDate: Wed Apr 13 19:19:16 2022 +0530
HDDS-6579. Add commandline argument for Container Info command. (#3306)
---
.../org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java | 7 ++++++-
.../apache/hadoop/hdds/scm/cli/container/TestInfoSubCommand.java | 2 +-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java b/hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java
index 7b0daa6de7..fd97153d79 100644
--- a/hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java
+++ b/hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java
@@ -63,6 +63,11 @@ public class InfoSubcommand extends ScmSubcommand {
description = "Format output as JSON")
private boolean json;
+ @CommandLine.Option(names = { "--replicas" },
+ defaultValue = "false",
+ description = "Adds replica related details")
+ private boolean addReplicaDetails;
+
@Parameters(description = "Decimal id of the container.")
private long containerID;
@@ -103,7 +108,7 @@ public class InfoSubcommand extends ScmSubcommand {
LOG.info("Datanodes: [{}]", machinesStr);
// Print the replica details if available
- if (replicas != null) {
+ if (addReplicaDetails && replicas != null) {
String replicaStr = replicas.stream().map(
InfoSubcommand::buildReplicaDetails)
.collect(Collectors.joining(",\n"));
diff --git a/hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/container/TestInfoSubCommand.java b/hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/container/TestInfoSubCommand.java
index a7960d8817..23a1a0b3a6 100644
--- a/hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/container/TestInfoSubCommand.java
+++ b/hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/container/TestInfoSubCommand.java
@@ -85,7 +85,7 @@ public class TestInfoSubCommand {
.thenReturn(getReplicas());
cmd = new InfoSubcommand();
CommandLine c = new CommandLine(cmd);
- c.parseArgs("1");
+ c.parseArgs("1", "--replicas");
cmd.execute(scmClient);
// Ensure we have a line for Replicas:
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ozone.apache.org
For additional commands, e-mail: commits-help@ozone.apache.org