You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/02 08:02:05 UTC
[GitHub] [incubator-celeborn] zwangsheng opened a new pull request, #1042: [IMPROVEMENT] Remove never reach code block in master/worker arguments
zwangsheng opened a new pull request, #1042:
URL: https://github.com/apache/incubator-celeborn/pull/1042
# [IMPROVEMENT] Remove never reach code block in master/worker arguments
### What changes were proposed in this pull request?
Host and port check will alway isn't null, due to default value.
Remove this un-reach code block to keep the code neat.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### What are the items that need reviewer attention?
### Related issues.
### Related pull requests.
### How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1042: [CELEBORN-98][IMPROVEMENT] Remove unreachable code block in master/work arguments
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu merged PR #1042:
URL: https://github.com/apache/incubator-celeborn/pull/1042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1042: [IMPROVEMENT] Remove never reach code block in master/worker arguments
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #1042:
URL: https://github.com/apache/incubator-celeborn/pull/1042#issuecomment-1334881772
Can you create a ISSUE and change title like `[CELEBORN-xxx][PR_TYPE] xxxx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1042: [CELEBORN-98][IMPROVEMENT] Remove unreachable code block in master/work arguments
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1042:
URL: https://github.com/apache/incubator-celeborn/pull/1042#discussion_r1037954784
##########
master/src/test/scala/org/apache/celeborn/service/deploy/master/MasterArgumentsSuite.scala:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.service.deploy.master
+
+import org.scalatest.funsuite.AnyFunSuite
+
+import org.apache.celeborn.common.CelebornConf
+import org.apache.celeborn.common.CelebornConf.{MASTER_HOST, MASTER_PORT}
+import org.apache.celeborn.common.internal.Logging
+import org.apache.celeborn.common.util.Utils
+
+class MasterArgumentsSuite extends AnyFunSuite with Logging {
+
+ test("Test build masterArguments") {
Review Comment:
Lets also add `CELEBORN-98: xxx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zwangsheng commented on a diff in pull request #1042: [CELEBORN-98][IMPROVEMENT] Remove unreachable code block in master/work arguments
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on code in PR #1042:
URL: https://github.com/apache/incubator-celeborn/pull/1042#discussion_r1037961379
##########
master/src/test/scala/org/apache/celeborn/service/deploy/master/MasterArgumentsSuite.scala:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.service.deploy.master
+
+import org.scalatest.funsuite.AnyFunSuite
+
+import org.apache.celeborn.common.CelebornConf
+import org.apache.celeborn.common.CelebornConf.{MASTER_HOST, MASTER_PORT}
+import org.apache.celeborn.common.internal.Logging
+import org.apache.celeborn.common.util.Utils
+
+class MasterArgumentsSuite extends AnyFunSuite with Logging {
+
+ test("Test build masterArguments") {
Review Comment:
OK, i'd like add more info to test case name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1042: [CELEBORN-98][IMPROVEMENT] Remove unreachable code block in master/work arguments
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1042:
URL: https://github.com/apache/incubator-celeborn/pull/1042#discussion_r1037968013
##########
worker/src/test/scala/org/apache/celeborn/service/deploy/WorkerArgumentsSuite.scala:
##########
@@ -27,7 +27,7 @@ import org.apache.celeborn.service.deploy.worker.WorkerArguments
class WorkerArgumentsSuite extends AnyFunSuite with Logging {
- test("Test build workerArguments") {
+ test("[CELEBORN-98] Test build workerArguments in different case\"") {
Review Comment:
Remove `\"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zwangsheng commented on a diff in pull request #1042: [CELEBORN-98][IMPROVEMENT] Remove unreachable code block in master/work arguments
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on code in PR #1042:
URL: https://github.com/apache/incubator-celeborn/pull/1042#discussion_r1037913284
##########
master/src/test/scala/org/apache/celeborn/service/deploy/master/MasterArgumentsSuite.scala:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.service.deploy.master
+
+import org.apache.celeborn.common.CelebornConf
+import org.apache.celeborn.common.internal.Logging
+import org.apache.celeborn.common.util.Utils
+import org.scalatest.funsuite.AnyFunSuite
+
+class MasterArgumentsSuite extends AnyFunSuite with Logging {
+
+ test("Test build masterArguments") {
+ import org.apache.celeborn.common.CelebornConf.{MASTER_HOST, MASTER_PORT}
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zwangsheng commented on pull request #1042: [IMPROVEMENT] Remove never reach code block in master/worker arguments
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #1042:
URL: https://github.com/apache/incubator-celeborn/pull/1042#issuecomment-1334882754
> an you create a ISSUE and change title like `[CELEBORN-xxx][PR_TYPE] xxxx`
Thanks for the reminder, i will open issue and add some unit tests later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1042: [CELEBORN-98][IMPROVEMENT] Remove unreachable code block in master/work arguments
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1042:
URL: https://github.com/apache/incubator-celeborn/pull/1042#discussion_r1037907380
##########
master/src/test/scala/org/apache/celeborn/service/deploy/master/MasterArgumentsSuite.scala:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.service.deploy.master
+
+import org.apache.celeborn.common.CelebornConf
+import org.apache.celeborn.common.internal.Logging
+import org.apache.celeborn.common.util.Utils
+import org.scalatest.funsuite.AnyFunSuite
+
+class MasterArgumentsSuite extends AnyFunSuite with Logging {
+
+ test("Test build masterArguments") {
+ import org.apache.celeborn.common.CelebornConf.{MASTER_HOST, MASTER_PORT}
Review Comment:
Move to import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org