[GitHub] [hive] kgyrtkirk commented on a change in pull request #2957: HIVE-25884: Improve rule description for rules defined as subclasses

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #2957:
URL: https://github.com/apache/hive/pull/2957#discussion_r800446246



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterJoinRule.java
##########
@@ -130,7 +130,7 @@ public void onMatch(RelOptRuleCall call) {
 
   public static class HiveFilterJoinTransposeRule extends HiveFilterJoinRule {
     public HiveFilterJoinTransposeRule() {
-      super(RelOptRule.operand(Join.class, RelOptRule.any()), "HiveFilterJoinRule:no-filter", true,
+      super(RelOptRule.operand(Join.class, RelOptRule.any()), "HiveFilterJoinTransposeRule", true,

Review comment:
       this could also be handled by `getClass().getSimpleName()` - I think that would have worked in the superclass as well




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org