You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/11/23 00:59:55 UTC
Review Request 40586: Corrected a typo and a formatting issue.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40586/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/quota/quota.hpp 8276749efbca167c56e337aa9155fb7db739c1c9
src/master/allocator/mesos/hierarchical.hpp c65fe35198b846da2dc959dd467a21ff6edd30a9
Diff: https://reviews.apache.org/r/40586/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40586: Corrected a typo and a formatting issue.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Nov. 23, 2015, 4:35 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.hpp, lines 367-377
> > <https://reviews.apache.org/r/40586/diff/1/?file=1135512#file1135512line367>
> >
> > Sorry, what is the update for this file?
removed extra blank line
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40586/#review107548
-----------------------------------------------------------
On Nov. 22, 2015, 11:59 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40586/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2015, 11:59 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/quota/quota.hpp 8276749efbca167c56e337aa9155fb7db739c1c9
> src/master/allocator/mesos/hierarchical.hpp c65fe35198b846da2dc959dd467a21ff6edd30a9
>
> Diff: https://reviews.apache.org/r/40586/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40586: Corrected a typo and a formatting issue.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40586/#review107548
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp (lines 367 - 376)
<https://reviews.apache.org/r/40586/#comment166772>
Sorry, what is the update for this file?
- Guangya Liu
On 十一月 22, 2015, 11:59 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40586/
> -----------------------------------------------------------
>
> (Updated 十一月 22, 2015, 11:59 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/quota/quota.hpp 8276749efbca167c56e337aa9155fb7db739c1c9
> src/master/allocator/mesos/hierarchical.hpp c65fe35198b846da2dc959dd467a21ff6edd30a9
>
> Diff: https://reviews.apache.org/r/40586/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40586: Corrected typos and formatting issues.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40586/#review108026
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Nov. 23, 2015, 11:33 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40586/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 11:33 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/quota/quota.hpp 2f8c31f3b90f966a84a6b67029080e7edddef24c
> src/master/allocator/mesos/hierarchical.hpp 2a21364fdcaa4ec5e5567b9f367c14a1579b9a49
> src/master/allocator/mesos/hierarchical.cpp aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a
>
> Diff: https://reviews.apache.org/r/40586/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40586: Corrected typos and formatting issues.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40586/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 11:33 p.m.)
Review request for mesos and Joris Van Remoortere.
Summary (updated)
-----------------
Corrected typos and formatting issues.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/quota/quota.hpp 2f8c31f3b90f966a84a6b67029080e7edddef24c
src/master/allocator/mesos/hierarchical.hpp 2a21364fdcaa4ec5e5567b9f367c14a1579b9a49
src/master/allocator/mesos/hierarchical.cpp aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a
Diff: https://reviews.apache.org/r/40586/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40586: Corrected typos and a formatting issue.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40586/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 5:38 p.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Corrected one more typo.
Summary (updated)
-----------------
Corrected typos and a formatting issue.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/quota/quota.hpp 8276749efbca167c56e337aa9155fb7db739c1c9
src/master/allocator/mesos/hierarchical.hpp c65fe35198b846da2dc959dd467a21ff6edd30a9
Diff: https://reviews.apache.org/r/40586/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov