You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Rahul Thakur (JIRA)" <ji...@codehaus.org> on 2006/10/30 01:17:10 UTC

[jira] Created: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Refactor Notifiers: Seprate hierarchy for Project and Project Group
-------------------------------------------------------------------

                 Key: CONTINUUM-976
                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
             Project: Continuum
          Issue Type: Task
          Components: IRC Notifier, Jabber Notifier, Mail Notifier, MSN Notifier, Web interface
    Affects Versions: 1.1
            Reporter: Rahul Thakur
         Attachments: CONTINUUM-976.patch

Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Rahul Thakur (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-976?page=all ]

Rahul Thakur updated CONTINUUM-976:
-----------------------------------

    Attachment: CONTINUUM-976.patch

Refactoring to notiifer hierarchy

> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Web interface, Mail Notifier, IRC Notifier, Jabber Notifier, MSN Notifier
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Rahul Thakur
>         Attachments: CONTINUUM-976.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Rahul Thakur (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-976?page=comments#action_78861 ] 
            
Rahul Thakur commented on CONTINUUM-976:
----------------------------------------

Note to myself: 
Review if continuum-webapp-test has correct Notifier references in (possibly generated) components.xml

> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Web interface, Mail Notifier, IRC Notifier, Jabber Notifier, MSN Notifier
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Rahul Thakur
>         Attachments: CONTINUUM-976.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-976?page=comments#action_81157 ] 
            
Emmanuel Venisse commented on CONTINUUM-976:
--------------------------------------------

Can you provide a new patch?

> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Web interface, Notifier - Mail, Notifier - IRC, Notifier - Jabber, Notifier - MSN
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Rahul Thakur
>         Attachments: CONTINUUM-976.patch, CONTINUUM-976a.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Rahul Thakur (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-976?page=comments#action_79944 ] 
            
Rahul Thakur commented on CONTINUUM-976:
----------------------------------------

Another incremental patch for notifiers. Could you patch please. 
Thanks

> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Web interface, Mail Notifier, IRC Notifier, Jabber Notifier, MSN Notifier
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Rahul Thakur
>         Attachments: CONTINUUM-976.patch, CONTINUUM-976a.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Rahul Thakur (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-976?page=comments#action_82534 ] 
            
Rahul Thakur commented on CONTINUUM-976:
----------------------------------------

Not yet, I picked it up from Jesse and working thru it  and committing incrementally.  

> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Web interface, Notifier - Mail, Notifier - IRC, Notifier - Jabber, Notifier - MSN
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Rahul Thakur
>         Attachments: CONTINUUM-967b.patch, CONTINUUM-976.patch, CONTINUUM-976a.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Rahul Thakur (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-976?page=all ]

Rahul Thakur updated CONTINUUM-976:
-----------------------------------

    Attachment: CONTINUUM-976a.patch

o  Project and Project Group Notifiers are now displayed by separate JSP fragments.
o  Some code cleanups



> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Web interface, Mail Notifier, IRC Notifier, Jabber Notifier, MSN Notifier
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Rahul Thakur
>         Attachments: CONTINUUM-976.patch, CONTINUUM-976a.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Rahul Thakur (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-976?page=comments#action_78767 ] 
            
Rahul Thakur commented on CONTINUUM-976:
----------------------------------------

Hi Jesse, 
Can you please patch this. I have to review and get the validations working again after the refactoring. 
Thanks


> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Web interface, Mail Notifier, IRC Notifier, Jabber Notifier, MSN Notifier
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Rahul Thakur
>         Attachments: CONTINUUM-976.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse closed CONTINUUM-976.
--------------------------------------

         Assignee: Emmanuel Venisse  (was: Rahul Thakur)
       Resolution: Fixed
    Fix Version/s: 1.1

Already done

> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Notifier - IRC, Notifier - Jabber, Notifier - Mail, Notifier - MSN, Web interface
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Emmanuel Venisse
>             Fix For: 1.1
>
>         Attachments: CONTINUUM-967b.patch, CONTINUUM-976.patch, CONTINUUM-976a.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Rahul Thakur (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-976?page=comments#action_81999 ] 
            
Rahul Thakur commented on CONTINUUM-976:
----------------------------------------

Jesse, 

can you please apply this - thanks! I could use some more 'power' :-) , its easier for me to make and check in few changes at a time. 

Cheers

> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Web interface, Notifier - Mail, Notifier - IRC, Notifier - Jabber, Notifier - MSN
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Rahul Thakur
>         Attachments: CONTINUUM-967b.patch, CONTINUUM-976.patch, CONTINUUM-976a.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Jesse McConnell (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-976?page=comments#action_82002 ] 
            
Jesse McConnell commented on CONTINUUM-976:
-------------------------------------------

applied the latest but not committing, ran into a couple of issues I went over with rahul

> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Web interface, Notifier - Mail, Notifier - IRC, Notifier - Jabber, Notifier - MSN
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Rahul Thakur
>         Attachments: CONTINUUM-967b.patch, CONTINUUM-976.patch, CONTINUUM-976a.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-976?page=comments#action_82517 ] 
            
Brett Porter commented on CONTINUUM-976:
----------------------------------------

is this applied now?

> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Web interface, Notifier - Mail, Notifier - IRC, Notifier - Jabber, Notifier - MSN
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Rahul Thakur
>         Attachments: CONTINUUM-967b.patch, CONTINUUM-976.patch, CONTINUUM-976a.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Rahul Thakur (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-976?page=all ]

Rahul Thakur updated CONTINUUM-976:
-----------------------------------

    Attachment: CONTINUUM-967b.patch

Update the last patch to work with latest updates to the trunk.

> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Web interface, Notifier - Mail, Notifier - IRC, Notifier - Jabber, Notifier - MSN
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Rahul Thakur
>         Attachments: CONTINUUM-967b.patch, CONTINUUM-976.patch, CONTINUUM-976a.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-976) Refactor Notifiers: Seprate hierarchy for Project and Project Group

Posted by "Jesse McConnell (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-976?page=comments#action_78863 ] 
            
Jesse McConnell commented on CONTINUUM-976:
-------------------------------------------

I cleaned this up a bit and applied it, I mostly changed the *ProjectGroupNotifierAction naming to *GroupNotifierAction since it seemed a little less redundant, but I had originally done that naming convention on the build definitions so if this works we can go back and fix that up later.  It was a bit of a pain getting the files patched since they were renamed and changed quite a bit, but should all be good.

I'll let you close it, or post some validation changes if you find any



> Refactor Notifiers: Seprate hierarchy for Project and Project Group
> -------------------------------------------------------------------
>
>                 Key: CONTINUUM-976
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-976
>             Project: Continuum
>          Issue Type: Task
>          Components: Web interface, Mail Notifier, IRC Notifier, Jabber Notifier, MSN Notifier
>    Affects Versions: 1.1
>            Reporter: Rahul Thakur
>         Assigned To: Rahul Thakur
>         Attachments: CONTINUUM-976.patch
>
>
> Refactor Notifiers hierarchy to be separate for Project and Project Group.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira