[GitHub] [dubbo-go-pixiu] PhilYue commented on a diff in pull request #475: [ASoC 2022] Optimization of Pixiu timeout feature

[GitBox <gi...@apache.org>]

PhilYue commented on code in PR #475:
URL: https://github.com/apache/dubbo-go-pixiu/pull/475#discussion_r963226732


##########
pkg/client/triple/triple.go:
##########
@@ -89,7 +90,10 @@ func (dc *Client) Call(req *client.Request) (res interface{}, err error) {
 	}
 	meta := make(map[string][]string)
 	reqData, _ := ioutil.ReadAll(req.IngressRequest.Body)
-	call, err := p.Call(context.Background(), req.API.Method.IntegrationRequest.Interface, req.API.Method.IntegrationRequest.Method, reqData, (*proxymeta.Metadata)(&meta))
+	ctx, cancel := context.WithTimeout(context.Background(), req.Timeout)
+	defer cancel()
+	time.Sleep(100 * time.Nanosecond)

Review Comment:
   why need sleep



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org