You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/01/28 13:02:03 UTC

[GitHub] [doris] jackwener opened a new pull request, #16170: [fix](Nereids): fix convert_tz() SIGNATURES.

jackwener opened a new pull request, #16170:
URL: https://github.com/apache/doris/pull/16170

   # Proposed changes
   
   we shouldn't add `DateV2` in `SIGNATURES`, because when meet `DateV2`, it will cast to `DateTimeV2Type` implicitly.
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #16170: [fix](Nereids): fix convert_tz() SIGNATURES.

Posted by github-actions.
github-actions[bot] commented on PR #16170:
URL: https://github.com/apache/doris/pull/16170#issuecomment-1407397943

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] jackwener merged pull request #16170: [fix](Nereids): remove `DataV2Type` in ConvertTz SIGNATURES

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #16170:
URL: https://github.com/apache/doris/pull/16170


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #16170: [fix](Nereids): remove `DataV2Type` in ConvertTz, DayCeil and DayFloor SIGNATURES

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16170:
URL: https://github.com/apache/doris/pull/16170#issuecomment-1407410262

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 35.13 seconds
    load time: 507 seconds
    storage size: 17122819584 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230128142720_clickbench_pr_85741.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #16170: [fix](Nereids): remove `DataV2Type` in ConvertTz SIGNATURES

Posted by github-actions.
github-actions[bot] commented on PR #16170:
URL: https://github.com/apache/doris/pull/16170#issuecomment-1407559890

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #16170: [fix](Nereids): fix convert_tz() SIGNATURES.

Posted by github-actions.
github-actions[bot] commented on PR #16170:
URL: https://github.com/apache/doris/pull/16170#issuecomment-1407397954

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] BiteTheDDDDt commented on pull request #16170: [fix](Nereids): remove `DataV2Type` in ConvertTz, DayCeil and DayFloor SIGNATURES

Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #16170:
URL: https://github.com/apache/doris/pull/16170#issuecomment-1407541545

   In my opinion, `convert_tz` does not need `datev2` as an input parameter, but `day_ceil` accepts datev2 is reasonable. You can remove them all temporarily, and we will investigate what is wrong with the implementation of `day_ceil` in `be` later.
   
   For this pr, I think you'd better make some changes in `doris_builtins_functions.py` to ensure that the function signatures of nereids and old planner are consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] BiteTheDDDDt commented on pull request #16170: [fix](Nereids): remove `DataV2Type` in ConvertTz, DayCeil and DayFloor SIGNATURES

Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #16170:
URL: https://github.com/apache/doris/pull/16170#issuecomment-1407431450

   On the one hand, you should make sure that the signature in nereids is consistent with the signature in doris_builtins_functions.py. On the other hand, whether a function like DayCeil should remove the datev2 type signature, I'm not sure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] Gabriel39 commented on pull request #16170: [fix](Nereids): remove `DataV2Type` in ConvertTz, DayCeil and DayFloor SIGNATURES

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #16170:
URL: https://github.com/apache/doris/pull/16170#issuecomment-1407541920

   Agree with @BiteTheDDDDt . Functions like `DayCeil ` still need to accept datev2 as argument instead of datetimev2. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org