You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "jiangxin369 (via GitHub)" <gi...@apache.org> on 2023/07/05 13:26:10 UTC

[GitHub] [flink-ml] jiangxin369 opened a new pull request, #246: [FLINK-32545] Improves the performance by optimizing row operations

jiangxin369 opened a new pull request, #246:
URL: https://github.com/apache/flink-ml/pull/246

   <!--
   *Thank you very much for contributing to Apache Flink ML - we are happy that you want to help us improve Flink ML. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to one [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] Title of the pull request`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
    Improves the performance by optimizing row operations.
   
   ## Brief change log
   
     - Adds RowUtils to help with Row operations.
     - Replaces all Row.join() function call with new utility.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] jiangxin369 commented on pull request #246: [FLINK-32545] Improves the performance by optimizing row operations

Posted by "jiangxin369 (via GitHub)" <gi...@apache.org>.
jiangxin369 commented on PR #246:
URL: https://github.com/apache/flink-ml/pull/246#issuecomment-1624846507

   @lindong28 Thanks for the reply.
   
   > For those algorithms which have the corresponding benchmark defined in ./flink-ml-benchmark/src/main/resources, can you run the benchmarks and document the performance improvements in the PR description?
   
   For those algorithms which are already defined in "./flink-ml-benchmark/src/main/resources", I have run the benchmark for them on my workstation, but most of them remain a similar performance as before. The reason is that the other algorithms are configured with a small dataset(1/10 of Bucketizer) to make it not run so long. The PR is optimized by reducing the cost of creating rows, the effect is positively correlated with dataset size.
   
   > Can you confirm that Bucketizer benchmark results are obtained by running `./flink-ml-benchmark/src/main/resources/bucketizer-benchmark.json`?
   
   Yes, it is.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] jiangxin369 commented on pull request #246: [FLINK-32545] Improves the performance by optimizing row operations

Posted by "jiangxin369 (via GitHub)" <gi...@apache.org>.
jiangxin369 commented on PR #246:
URL: https://github.com/apache/flink-ml/pull/246#issuecomment-1623085063

   @lindong28 Could you have a review at this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #246: [FLINK-32545] Improves the performance by optimizing row operations

Posted by "lindong28 (via GitHub)" <gi...@apache.org>.
lindong28 commented on PR #246:
URL: https://github.com/apache/flink-ml/pull/246#issuecomment-1624627981

   Thanks for the PR!
   
   For those algorithms which have the corresponding benchmark defined in ./flink-ml-benchmark/src/main/resources, can you run the benchmarks and document the performance improvements in the PR description?
   
   Can you confirm that Bucketizer benchmark results are obtained by running `./flink-ml-benchmark/src/main/resources/bucketizer-benchmark.json`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #246: [FLINK-32545] Improves the performance by optimizing row operations

Posted by "lindong28 (via GitHub)" <gi...@apache.org>.
lindong28 commented on PR #246:
URL: https://github.com/apache/flink-ml/pull/246#issuecomment-1639527488

   Thanks for the PR! LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 merged pull request #246: [FLINK-32545] Improves the performance by optimizing row operations

Posted by "lindong28 (via GitHub)" <gi...@apache.org>.
lindong28 merged PR #246:
URL: https://github.com/apache/flink-ml/pull/246


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #246: [FLINK-32545] Improves the performance by optimizing row operations

Posted by "lindong28 (via GitHub)" <gi...@apache.org>.
lindong28 commented on PR #246:
URL: https://github.com/apache/flink-ml/pull/246#issuecomment-1624871748

   @jiangxin369 Can you help update the configuration of these machines so that they can run for e.g 30-60 seconds and validate the performance improvement of this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] jiangxin369 commented on pull request #246: [FLINK-32545] Improves the performance by optimizing row operations

Posted by "jiangxin369 (via GitHub)" <gi...@apache.org>.
jiangxin369 commented on PR #246:
URL: https://github.com/apache/flink-ml/pull/246#issuecomment-1625322947

   > @jiangxin369 Can you help update the configuration of these benchmarks so that they can run for e.g 30-60 seconds and validate the performance improvement of this PR?
   
   Sure, I have updated the PR and the description. Btw,  I'm surprised that some of the benchmarks are corrupted at runtime, I hotfix them in this PR but I think we need some strategies to detect it in advance, maybe run all benchmarks with a tiny input dataset in CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org