You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/05/03 19:18:24 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #2212: HDDS-5182. Acceptance test may exit with 0 in case of error
adoroszlai opened a new pull request #2212:
URL: https://github.com/apache/ozone/pull/2212
## What changes were proposed in this pull request?
If any acceptance test fails, `test-all.sh` (and in turn `acceptance.sh`) should exit with error code (1). But if a successful test is run after a failing one, it will now wrongly exit with success (0).
```
$ export OZONE_TEST_SELECTOR='failing1\|ozone-csi'
$ ./hadoop-ozone/dev-support/checks/acceptance.sh
...
$ echo $?
0
```
The problem is that the variable `ret` in the functions `run_test_scripts` and `run_test_script` are intended to be independent, but are the same (global) one.
https://issues.apache.org/jira/browse/HDDS-5182
## How was this patch tested?
```
$ export OZONE_TEST_SELECTOR='failing1\|ozone-csi'
$ ./hadoop-ozone/dev-support/checks/acceptance.sh
...
$ echo $?
1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #2212: HDDS-5182. Acceptance test may exit with 0 in case of error
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2212:
URL: https://github.com/apache/ozone/pull/2212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2212: HDDS-5182. Acceptance test may exit with 0 in case of error
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2212:
URL: https://github.com/apache/ozone/pull/2212#issuecomment-831716318
Thanks @cxorm for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org