You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Erik Holstad (JIRA)" <ji...@apache.org> on 2009/07/07 08:44:14 UTC

[jira] Created: (HBASE-1619) Change the familyMap> in put to familyMap>

Change the familyMap<byte[], List<KeyValue>> in put to  familyMap<ImmutableBytesWritable, List<KeyValue>>
---------------------------------------------------------------------------------------------------------

                 Key: HBASE-1619
                 URL: https://issues.apache.org/jira/browse/HBASE-1619
             Project: Hadoop HBase
          Issue Type: Improvement
    Affects Versions: 0.20.0
            Reporter: Erik Holstad
            Priority: Minor
             Fix For: 0.20.0


While working on the HBase tap and scheme for Cascading I came across a situation where you want to add a bunch of KeyValues to a Put object.
Looking at the code for putting KeyValues in put we copy the family from the KeyValue and use that as a key. So I was thinking that it might be a good idea to just "point"
into the KV by using a ImmutableBytesWritable and use that as the key instead. This is going to be good when working with MR jobs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1619) Change the familyMap> in put to familyMap>

Posted by "Erik Holstad (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728259#action_12728259 ] 

Erik Holstad commented on HBASE-1619:
-------------------------------------

@JGray, haha, yeah I think so.

@Stack, I'm going to file a couple of issues during this week related to Cascading and have no problem moving them out of 0.20 if everything else is done. But don't think that they are going to big and complicated and take a lot of time to fix.

> Change the familyMap<byte[], List<KeyValue>> in put to  familyMap<ImmutableBytesWritable, List<KeyValue>>
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1619
>                 URL: https://issues.apache.org/jira/browse/HBASE-1619
>             Project: Hadoop HBase
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Erik Holstad
>            Priority: Minor
>             Fix For: 0.20.0
>
>
> While working on the HBase tap and scheme for Cascading I came across a situation where you want to add a bunch of KeyValues to a Put object.
> Looking at the code for putting KeyValues in put we copy the family from the KeyValue and use that as a key. So I was thinking that it might be a good idea to just "point"
> into the KV by using a ImmutableBytesWritable and use that as the key instead. This is going to be good when working with MR jobs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1619) Change the familyMap> in put to familyMap>

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727973#action_12727973 ] 

Jonathan Gray commented on HBASE-1619:
--------------------------------------

Doesn't this raise the instantiable Bytes vs continuing down the unpleasant road of IBW question?  See, I can't even write it out!

> Change the familyMap<byte[], List<KeyValue>> in put to  familyMap<ImmutableBytesWritable, List<KeyValue>>
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1619
>                 URL: https://issues.apache.org/jira/browse/HBASE-1619
>             Project: Hadoop HBase
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Erik Holstad
>            Priority: Minor
>             Fix For: 0.20.0
>
>
> While working on the HBase tap and scheme for Cascading I came across a situation where you want to add a bunch of KeyValues to a Put object.
> Looking at the code for putting KeyValues in put we copy the family from the KeyValue and use that as a key. So I was thinking that it might be a good idea to just "point"
> into the KV by using a ImmutableBytesWritable and use that as the key instead. This is going to be good when working with MR jobs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1619) Change the familyMap> in put to familyMap>

Posted by "Erik Holstad (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728475#action_12728475 ] 

Erik Holstad commented on HBASE-1619:
-------------------------------------

This can also be used for the row, in multiple places. For example Result and Put where we can just reference the row in the first KeyValue.

> Change the familyMap<byte[], List<KeyValue>> in put to  familyMap<ImmutableBytesWritable, List<KeyValue>>
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1619
>                 URL: https://issues.apache.org/jira/browse/HBASE-1619
>             Project: Hadoop HBase
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Erik Holstad
>            Priority: Minor
>             Fix For: 0.20.1
>
>
> While working on the HBase tap and scheme for Cascading I came across a situation where you want to add a bunch of KeyValues to a Put object.
> Looking at the code for putting KeyValues in put we copy the family from the KeyValue and use that as a key. So I was thinking that it might be a good idea to just "point"
> into the KV by using a ImmutableBytesWritable and use that as the key instead. This is going to be good when working with MR jobs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1619) Change the familyMap> in put to familyMap>

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1619:
-------------------------

    Fix Version/s:     (was: 0.20.1)
                   0.21.0

Moving this optimization to 0.21.0

> Change the familyMap<byte[], List<KeyValue>> in put to  familyMap<ImmutableBytesWritable, List<KeyValue>>
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1619
>                 URL: https://issues.apache.org/jira/browse/HBASE-1619
>             Project: Hadoop HBase
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Erik Holstad
>            Priority: Minor
>             Fix For: 0.21.0
>
>
> While working on the HBase tap and scheme for Cascading I came across a situation where you want to add a bunch of KeyValues to a Put object.
> Looking at the code for putting KeyValues in put we copy the family from the KeyValue and use that as a key. So I was thinking that it might be a good idea to just "point"
> into the KV by using a ImmutableBytesWritable and use that as the key instead. This is going to be good when working with MR jobs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1619) Change the familyMap> in put to familyMap>

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728194#action_12728194 ] 

stack commented on HBASE-1619:
------------------------------

Seems like a nice-to-have optimization.  Move out of 0.20.0?

> Change the familyMap<byte[], List<KeyValue>> in put to  familyMap<ImmutableBytesWritable, List<KeyValue>>
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1619
>                 URL: https://issues.apache.org/jira/browse/HBASE-1619
>             Project: Hadoop HBase
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Erik Holstad
>            Priority: Minor
>             Fix For: 0.20.0
>
>
> While working on the HBase tap and scheme for Cascading I came across a situation where you want to add a bunch of KeyValues to a Put object.
> Looking at the code for putting KeyValues in put we copy the family from the KeyValue and use that as a key. So I was thinking that it might be a good idea to just "point"
> into the KV by using a ImmutableBytesWritable and use that as the key instead. This is going to be good when working with MR jobs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1619) Change the familyMap> in put to familyMap>

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1619:
-------------------------

    Fix Version/s:     (was: 0.20.0)
                   0.20.1

Ok Erik.  Moving out for now.

> Change the familyMap<byte[], List<KeyValue>> in put to  familyMap<ImmutableBytesWritable, List<KeyValue>>
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1619
>                 URL: https://issues.apache.org/jira/browse/HBASE-1619
>             Project: Hadoop HBase
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Erik Holstad
>            Priority: Minor
>             Fix For: 0.20.1
>
>
> While working on the HBase tap and scheme for Cascading I came across a situation where you want to add a bunch of KeyValues to a Put object.
> Looking at the code for putting KeyValues in put we copy the family from the KeyValue and use that as a key. So I was thinking that it might be a good idea to just "point"
> into the KV by using a ImmutableBytesWritable and use that as the key instead. This is going to be good when working with MR jobs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.