You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cuspymd <gi...@git.apache.org> on 2016/12/09 15:06:58 UTC
[GitHub] zeppelin pull request #1742: [ZEPPELIN-1781] Failed to run the script 'test_...
GitHub user cuspymd opened a pull request:
https://github.com/apache/zeppelin/pull/1742
[ZEPPELIN-1781] Failed to run the script 'test_zeppelin_pr.py' on Windows 10
### What is this PR for?
Fix failure of script execution on Windows 10
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
[ZEPPELIN-1781](https://issues.apache.org/jira/browse/ZEPPELIN-1781)
### How should this be tested?
Run 'test_zeppelin_pr.py' on Windows 10.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cuspymd/zeppelin test-pr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1742.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1742
----
commit eb4b5670ab3c2f31d188e5ee806290d666f26bb8
Author: Myoungdo Park <cu...@gmail.com>
Date: 2016-12-09T14:50:20Z
Fix failure of script execution on Windows 10
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1742: [ZEPPELIN-1781] Failed to run the script 'test_zeppeli...
Posted by cuspymd <gi...@git.apache.org>.
Github user cuspymd commented on the issue:
https://github.com/apache/zeppelin/pull/1742
@felixcheung The script 'test_zeppelin_pr.py' could be run on only Python 2 before this PR.
Anyway, I made additional modifications to run in python 3 as well.
And the script 'test_zeppelin_pr.py' is for development, not for ptyhon interpreter.
I can't found a unit test about the scripts of 'dev' folder.
Can you let me know if it exists, or do you think you need to test the scripts of 'dev' folder in the future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1742: [ZEPPELIN-1781] Failed to run the script 'test_zeppeli...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1742
ah, sorry for missing this earlier. I didn't realize this is dev/test_* - these are test scripts that do not have automated tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1742: [ZEPPELIN-1781] Failed to run the script 'test_...
Posted by cuspymd <gi...@git.apache.org>.
Github user cuspymd closed the pull request at:
https://github.com/apache/zeppelin/pull/1742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1742: [ZEPPELIN-1781] Failed to run the script 'test_zeppeli...
Posted by cuspymd <gi...@git.apache.org>.
Github user cuspymd commented on the issue:
https://github.com/apache/zeppelin/pull/1742
@felixcheung
I opened the PR again, but there was errors elsewhere. Zeppelin test seems unstable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1742: [ZEPPELIN-1781] Failed to run the script 'test_...
Posted by cuspymd <gi...@git.apache.org>.
Github user cuspymd closed the pull request at:
https://github.com/apache/zeppelin/pull/1742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1742: [ZEPPELIN-1781] Failed to run the script 'test_zeppeli...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1742
@cuspymd have you tested this with Python 2.x and Python 3.x? I'm not sure we have automated test covered for Python + Spark on both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1742: [ZEPPELIN-1781] Failed to run the script 'test_zeppeli...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1742
So there were 2 runs
The older run https://travis-ci.org/apache/zeppelin/jobs/182613697 failed with Spark cluster tests
The newer run https://travis-ci.org/apache/zeppelin/builds/183250971 failed with cassandra tests
Given that and no code changes between, I think we could attribute the failures to flaky test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1742: [ZEPPELIN-1781] Failed to run the script 'test_zeppeli...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1742
sorry I didnt see this. LGTM, CI passed,
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1742: [ZEPPELIN-1781] Failed to run the script 'test_zeppeli...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1742
Looks like the Python2 CI test failed, could you take a look?
```
16/12/09 15:15:01 INFO PySparkInterpreter: File /tmp/zeppelin_pyspark-9170445727539307406.py created
16/12/09 15:15:01 INFO SparkInterpreter: Sending metainfos to Zeppelin server: {url=http://172.17.0.14:4040}
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 132.031 sec <<< FAILURE! - in org.apache.zeppelin.spark.PySparkInterpreterTest
testBasicIntp(org.apache.zeppelin.spark.PySparkInterpreterTest) Time elapsed: 129.658 sec <<< FAILURE!
java.lang.AssertionError: expected:<SUCCESS> but was:<ERROR>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at org.apache.zeppelin.spark.PySparkInterpreterTest.testBasicIntp(PySparkInterpreterTest.java:128)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1742: [ZEPPELIN-1781] Failed to run the script 'test_...
Posted by cuspymd <gi...@git.apache.org>.
GitHub user cuspymd reopened a pull request:
https://github.com/apache/zeppelin/pull/1742
[ZEPPELIN-1781] Failed to run the script 'test_zeppelin_pr.py' on Windows 10
### What is this PR for?
Fix failure of script execution on Windows 10
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
[ZEPPELIN-1781](https://issues.apache.org/jira/browse/ZEPPELIN-1781)
### How should this be tested?
Run 'test_zeppelin_pr.py' on Windows 10.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cuspymd/zeppelin test-pr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1742.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1742
----
commit eb4b5670ab3c2f31d188e5ee806290d666f26bb8
Author: Myoungdo Park <cu...@gmail.com>
Date: 2016-12-09T14:50:20Z
Fix failure of script execution on Windows 10
commit c4682129662e5c4680f4fc33314ef812e4132f57
Author: Myoungdo Park <cu...@gmail.com>
Date: 2016-12-13T17:17:09Z
Make it runnable on Python 2/3
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1742: [ZEPPELIN-1781] Failed to run the script 'test_...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1742: [ZEPPELIN-1781] Failed to run the script 'test_zeppeli...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1742
merged to master. thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1742: [ZEPPELIN-1781] Failed to run the script 'test_...
Posted by cuspymd <gi...@git.apache.org>.
GitHub user cuspymd reopened a pull request:
https://github.com/apache/zeppelin/pull/1742
[ZEPPELIN-1781] Failed to run the script 'test_zeppelin_pr.py' on Windows 10
### What is this PR for?
Fix failure of script execution on Windows 10
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
[ZEPPELIN-1781](https://issues.apache.org/jira/browse/ZEPPELIN-1781)
### How should this be tested?
Run 'test_zeppelin_pr.py' on Windows 10.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cuspymd/zeppelin test-pr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1742.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1742
----
commit eb4b5670ab3c2f31d188e5ee806290d666f26bb8
Author: Myoungdo Park <cu...@gmail.com>
Date: 2016-12-09T14:50:20Z
Fix failure of script execution on Windows 10
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---