[GitHub] [flink] tweise commented on a diff in pull request #20530: [FLINK-28817] NullPointerException in HybridSource when restoring from checkpoint

[GitBox <gi...@apache.org>]

tweise commented on code in PR #20530:
URL: https://github.com/apache/flink/pull/20530#discussion_r943571890


##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplitEnumeratorTest.java:
##########
@@ -177,6 +177,26 @@ public void testRestoreEnumerator() throws Exception {
                 .hasSize(1);
     }
 
+    @Test
+    public void testRestoreEnumeratorWith2ndSource() throws Exception {

Review Comment:
   Let's try to find a name for this test case that better reflects the issue? What we are testing is restore with second or subsequent source after the first source did not assign any splits? The latter is key to the issue, because the reader does not (need to) track the last seen source index. How about `testRestoreEnumeratorAfterFirstSourceWithoutRestoredSplits`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org