You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/09 09:10:51 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #8143: ARROW-9949: [C++] Improve performance of Decimal128::FromString by 46%, and make the implementation reusable for Decimal256.

pitrou commented on a change in pull request #8143:
URL: https://github.com/apache/arrow/pull/8143#discussion_r485460551



##########
File path: cpp/src/arrow/util/decimal.cc
##########
@@ -42,34 +45,40 @@ namespace arrow {
 using internal::SafeLeftShift;
 using internal::SafeSignedAdd;
 
+#ifdef __SIZEOF_INT128__
+using uint128_t = __uint128_t;
+#else
+using boost::multiprecision::uint128_t;
+#endif

Review comment:
       Can we centralize this definition in e.g. `src/arrow/util/int128_internal.h`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org