[GitHub] [libcloud] Kami commented on a change in pull request #1293: Enable to specify project id in OpenStack OIDC auth

[GitBox <gi...@apache.org>]

Kami commented on a change in pull request #1293: Enable to specify project id in OpenStack OIDC auth
URL: https://github.com/apache/libcloud/pull/1293#discussion_r296445197
 
 

 ##########
 File path: libcloud/test/common/test_openstack_identity.py
 ##########
 @@ -790,14 +788,16 @@ def _v3_OS_FEDERATION_identity_providers_idp_protocols_oidc_auth(self, method, u
     def _v3_OS_FEDERATION_projects(self, method, url, body, headers):
         if method == 'GET':
             # get user projects
-            body = json.dumps({"projects": [{"id": "project_id"}]})
+            body = json.dumps({"projects": [{"id": "project_id", "name": "project_name"},
+                                            {"id": "project_id2", "name": "project_name2"}]})
             return (httplib.OK, body, self.json_content_headers, httplib.responses[httplib.OK])
         raise NotImplementedError()
 
     def _v3_auth_projects(self, method, url, body, headers):
         if method == 'GET':
             # get user projects
-            body = json.dumps({"projects": [{"id": "project_id"}]})
+            body = json.dumps({"projects": [{"id": "project_id", "name": "project_name"},
 
 Review comment:
   It would also be good to add a test case for scenario where invalid project id is specified.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services