You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Hanifi Gunes <ha...@gmail.com> on 2015/05/12 00:08:57 UTC
Review Request 34062: DRILL-3027: Add convenience methods to test
builder for creating nested baseline values
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34062/
-----------------------------------------------------------
Review request for drill, Jason Altekruse and Parth Chandra.
Repository: drill-git
Description
-------
DRILL-3027: Add convenience methods to test builder for creating nested baseline values
Diffs
-----
exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java 13f958c22315bf546c1eafb164bcf86c85197e66
Diff: https://reviews.apache.org/r/34062/diff/
Testing
-------
none -- methods are not in use.
Thanks,
Hanifi Gunes
Re: Review Request 34062: DRILL-3027: Add convenience methods to test
builder for creating nested baseline values
Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34062/#review83311
-----------------------------------------------------------
Ship it!
Ship It!
- Jason Altekruse
On May 11, 2015, 11:09 p.m., Hanifi Gunes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34062/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 11:09 p.m.)
>
>
> Review request for drill, Jason Altekruse and Parth Chandra.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-3027: Add convenience methods to test builder for creating nested baseline values
>
>
> Diffs
> -----
>
> exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java db1ed348a7edc7c1ee3b92491e34dbce7047d27a
> exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java 13f958c22315bf546c1eafb164bcf86c85197e66
> exec/java-exec/src/test/java/org/apache/drill/TestFrameworkTest.java c6e81a996fa3037b9e4bafddb82d200b5d9ebcc3
> exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java dfa89caed54abb871e3d2a346bd5f639d321fa06
>
> Diff: https://reviews.apache.org/r/34062/diff/
>
>
> Testing
> -------
>
> TestFrameworkTest, TestJsonReader
>
>
> Thanks,
>
> Hanifi Gunes
>
>
Re: Review Request 34062: DRILL-3027: Add convenience methods to test
builder for creating nested baseline values
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34062/
-----------------------------------------------------------
(Updated May 11, 2015, 11:09 p.m.)
Review request for drill, Jason Altekruse and Parth Chandra.
Changes
-------
Replaced static imports.
Repository: drill-git
Description
-------
DRILL-3027: Add convenience methods to test builder for creating nested baseline values
Diffs (updated)
-----
exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java db1ed348a7edc7c1ee3b92491e34dbce7047d27a
exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java 13f958c22315bf546c1eafb164bcf86c85197e66
exec/java-exec/src/test/java/org/apache/drill/TestFrameworkTest.java c6e81a996fa3037b9e4bafddb82d200b5d9ebcc3
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java dfa89caed54abb871e3d2a346bd5f639d321fa06
Diff: https://reviews.apache.org/r/34062/diff/
Testing
-------
TestFrameworkTest, TestJsonReader
Thanks,
Hanifi Gunes
Re: Review Request 34062: DRILL-3027: Add convenience methods to test
builder for creating nested baseline values
Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34062/#review83307
-----------------------------------------------------------
Ship it!
Just a minor style change to match import conventions, then I'm +1
exec/java-exec/src/test/java/org/apache/drill/TestFrameworkTest.java
<https://reviews.apache.org/r/34062/#comment134244>
Wildcard import, see other comment.
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java
<https://reviews.apache.org/r/34062/#comment134243>
I'm pretty sure we have a checkstyle rule to disable wildcard imports. In any case we have kept them out of the rest of the project so it would probably be better not to add one here.
- Jason Altekruse
On May 11, 2015, 10:55 p.m., Hanifi Gunes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34062/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 10:55 p.m.)
>
>
> Review request for drill, Jason Altekruse and Parth Chandra.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-3027: Add convenience methods to test builder for creating nested baseline values
>
>
> Diffs
> -----
>
> exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java db1ed348a7edc7c1ee3b92491e34dbce7047d27a
> exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java 13f958c22315bf546c1eafb164bcf86c85197e66
> exec/java-exec/src/test/java/org/apache/drill/TestFrameworkTest.java c6e81a996fa3037b9e4bafddb82d200b5d9ebcc3
> exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java dfa89caed54abb871e3d2a346bd5f639d321fa06
>
> Diff: https://reviews.apache.org/r/34062/diff/
>
>
> Testing
> -------
>
> TestFrameworkTest, TestJsonReader
>
>
> Thanks,
>
> Hanifi Gunes
>
>
Re: Review Request 34062: DRILL-3027: Add convenience methods to test
builder for creating nested baseline values
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34062/
-----------------------------------------------------------
(Updated May 11, 2015, 10:55 p.m.)
Review request for drill, Jason Altekruse and Parth Chandra.
Changes
-------
Addressed Jason's verbal feedback.
- Removed non-static list & map from BaseTestQuery updated affected test cases.
- Added static listOf & mapOf methods to TestBuilder & documented
- listOf & mapOf converts any CharSequence to hadoop.io.Text
Repository: drill-git
Description
-------
DRILL-3027: Add convenience methods to test builder for creating nested baseline values
Diffs (updated)
-----
exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java db1ed348a7edc7c1ee3b92491e34dbce7047d27a
exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java 13f958c22315bf546c1eafb164bcf86c85197e66
exec/java-exec/src/test/java/org/apache/drill/TestFrameworkTest.java c6e81a996fa3037b9e4bafddb82d200b5d9ebcc3
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java dfa89caed54abb871e3d2a346bd5f639d321fa06
Diff: https://reviews.apache.org/r/34062/diff/
Testing (updated)
-------
TestFrameworkTest, TestJsonReader
Thanks,
Hanifi Gunes