You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/17 05:35:42 UTC
[GitHub] [flink] KarmaGYZ opened a new pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
KarmaGYZ opened a new pull request #15249:
URL: https://github.com/apache/flink/pull/15249
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
}, {
"hash" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933",
"triggerID" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"triggerType" : "PUSH"
}, {
"hash" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15146",
"triggerID" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0c4bc230a6e236de268e7c14a83cb8a446aeb1e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933)
* 011a96e4641ba00f16db6d6f6e300043e8dcf312 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15146)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #15249:
URL: https://github.com/apache/flink/pull/15249#discussion_r596065832
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/SlotInfo.java
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.taskmanager;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.types.ResourceProfile;
+import org.apache.flink.runtime.rest.messages.ResourceProfileInfo;
+import org.apache.flink.runtime.rest.messages.ResponseBody;
+import org.apache.flink.runtime.rest.messages.json.JobIDDeserializer;
+import org.apache.flink.runtime.rest.messages.json.JobIDSerializer;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.annotation.JsonDeserialize;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.annotation.JsonSerialize;
+
+import java.io.Serializable;
+import java.util.Objects;
+
+/**
+ * Class containing information for a slot of {@link
+ * org.apache.flink.runtime.resourcemanager.slotmanager.TaskManagerSlot}.
+ */
+public class SlotInfo implements ResponseBody, Serializable {
+ private static final long serialVersionUID = 1L;
+
+ public static final String FIELD_NAME_RESOURCE = "resource";
+
+ public static final String FIELD_NAME_JOB_ID = "jobId";
+
+ @JsonProperty(FIELD_NAME_RESOURCE)
+ private final ResourceProfileInfo resource;
+
+ @JsonProperty(FIELD_NAME_JOB_ID)
+ @JsonSerialize(using = JobIDSerializer.class)
+ private final JobID jobId;
+
+ @JsonCreator
+ public SlotInfo(
+ @JsonDeserialize(using = JobIDDeserializer.class) @JsonProperty(FIELD_NAME_JOB_ID)
+ JobID jobId,
+ @JsonProperty(FIELD_NAME_RESOURCE) ResourceProfileInfo resource) {
+ this.jobId = Preconditions.checkNotNull(jobId);
+ this.resource = Preconditions.checkNotNull(resource);
+ }
+
+ public SlotInfo(JobID jobId, ResourceProfile resource) {
+ this(jobId, ResourceProfileInfo.fromResrouceProfile(resource));
+ }
+
+ public JobID getJobId() {
+ return jobId;
+ }
+
+ public ResourceProfileInfo getResource() {
+ return resource;
+ }
Review comment:
getters should be annotated with `@JsonIgnore` to prevent accidends when fields are renamed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #15249:
URL: https://github.com/apache/flink/pull/15249#discussion_r596064244
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java
##########
@@ -636,6 +637,15 @@ public ResourceProfile getFreeResourceOf(InstanceID instanceID) {
return taskManagerTracker.getRegisteredResourceOf(instanceID);
}
+ @Override
+ public Collection<SlotInfo> getAllocatedSlotsOf(InstanceID instanceID) {
+ return taskManagerTracker.getRegisteredTaskManager(instanceID)
+ .map(TaskManagerInfo::getAllocatedSlots).map(Map::values)
+ .orElse(Collections.emptyList()).stream()
+ .map(slot -> new SlotInfo(slot.getJobId(), slot.getResourceProfile()))
+ .collect(Collectors.toList());
Review comment:
This will scale terribly. Do we really need information for every single slot?
Why not slots + number of slots of that type? Or total acquired resources? Or available/total resources of the TM?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2dc50c51f1d32acaa043173e508a9a3090e2fe03 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867)
* 2aea1ede2fcf41ea68f92dad2efb3936d284269c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #15249:
URL: https://github.com/apache/flink/pull/15249#discussion_r597364645
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java
##########
@@ -636,6 +637,15 @@ public ResourceProfile getFreeResourceOf(InstanceID instanceID) {
return taskManagerTracker.getRegisteredResourceOf(instanceID);
}
+ @Override
+ public Collection<SlotInfo> getAllocatedSlotsOf(InstanceID instanceID) {
+ return taskManagerTracker.getRegisteredTaskManager(instanceID)
+ .map(TaskManagerInfo::getAllocatedSlots).map(Map::values)
+ .orElse(Collections.emptyList()).stream()
+ .map(slot -> new SlotInfo(slot.getJobId(), slot.getResourceProfile()))
+ .collect(Collectors.toList());
Review comment:
I think how to expose that information to the user is depends on the WebUI and might be out of the scope of this PR. In current interface, we give the UI flexibility to choose how to aggregate it.
Also, user might want to know the explicit resource of each task, especially for external resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-801585649
Thanks for the comments @zentol . PR updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #15249:
URL: https://github.com/apache/flink/pull/15249#discussion_r596505083
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java
##########
@@ -636,6 +637,15 @@ public ResourceProfile getFreeResourceOf(InstanceID instanceID) {
return taskManagerTracker.getRegisteredResourceOf(instanceID);
}
+ @Override
+ public Collection<SlotInfo> getAllocatedSlotsOf(InstanceID instanceID) {
+ return taskManagerTracker.getRegisteredTaskManager(instanceID)
+ .map(TaskManagerInfo::getAllocatedSlots).map(Map::values)
+ .orElse(Collections.emptyList()).stream()
+ .map(slot -> new SlotInfo(slot.getJobId(), slot.getResourceProfile()))
+ .collect(Collectors.toList());
Review comment:
Currently, we already have the available/total resources of the TM. For fine-grained resource management, slots are dynamically created with different resource profiles. It would be good to let user know the what type of slot is allocated and which job it is allocated for. I don't think it will help a lot to reorganize it to slots + number of slots of that type. In the worst case, that will increase the data size instead.
After an offline discussion with @vthinkxie , I think we can add only this information to `TaskManagerDetailsInfo`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
}, {
"hash" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933",
"triggerID" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"triggerType" : "PUSH"
}, {
"hash" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15146",
"triggerID" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"triggerType" : "PUSH"
}, {
"hash" : "427a90e5913a3e7561b7c3ea2a85214b5a609969",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15150",
"triggerID" : "427a90e5913a3e7561b7c3ea2a85214b5a609969",
"triggerType" : "PUSH"
}, {
"hash" : "709ccb44a94b9938cf43e5cd0893207544869ce4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "709ccb44a94b9938cf43e5cd0893207544869ce4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 011a96e4641ba00f16db6d6f6e300043e8dcf312 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15146)
* 427a90e5913a3e7561b7c3ea2a85214b5a609969 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15150)
* 709ccb44a94b9938cf43e5cd0893207544869ce4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #15249:
URL: https://github.com/apache/flink/pull/15249#discussion_r596505083
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java
##########
@@ -636,6 +637,15 @@ public ResourceProfile getFreeResourceOf(InstanceID instanceID) {
return taskManagerTracker.getRegisteredResourceOf(instanceID);
}
+ @Override
+ public Collection<SlotInfo> getAllocatedSlotsOf(InstanceID instanceID) {
+ return taskManagerTracker.getRegisteredTaskManager(instanceID)
+ .map(TaskManagerInfo::getAllocatedSlots).map(Map::values)
+ .orElse(Collections.emptyList()).stream()
+ .map(slot -> new SlotInfo(slot.getJobId(), slot.getResourceProfile()))
+ .collect(Collectors.toList());
Review comment:
Currently, we already have the available/total resources of the TM. For fine-grained resource management, slots are dynamically created with different resource profiles. It would be good to let user know the what type of slot is allocated and which job it is allocated for. I don't think it will help allocate to reorganize it to slots + number of slots of that type. In the worst case, that will increase the data size instead.
After an offline discussion with @vthinkxie , I think we can add only this information to `TaskManagerDetailsInfo`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #15249:
URL: https://github.com/apache/flink/pull/15249#discussion_r596061798
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerInfo.java
##########
@@ -62,6 +63,8 @@
public static final String FIELD_NAME_MEMORY = "memoryConfiguration";
+ public static final String FIELD_NAME_ALLOCATE_SLOTS = "allocateSlots";
Review comment:
```suggestion
public static final String FIELD_NAME_ALLOCATE_SLOTS = "allocatedSlots";
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
}, {
"hash" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933",
"triggerID" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0c4bc230a6e236de268e7c14a83cb8a446aeb1e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #15249:
URL: https://github.com/apache/flink/pull/15249#discussion_r596505083
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java
##########
@@ -636,6 +637,15 @@ public ResourceProfile getFreeResourceOf(InstanceID instanceID) {
return taskManagerTracker.getRegisteredResourceOf(instanceID);
}
+ @Override
+ public Collection<SlotInfo> getAllocatedSlotsOf(InstanceID instanceID) {
+ return taskManagerTracker.getRegisteredTaskManager(instanceID)
+ .map(TaskManagerInfo::getAllocatedSlots).map(Map::values)
+ .orElse(Collections.emptyList()).stream()
+ .map(slot -> new SlotInfo(slot.getJobId(), slot.getResourceProfile()))
+ .collect(Collectors.toList());
Review comment:
Currently, we already have the available/total resources of the TM. For fine-grained resource management, slots are dynamically created with different resource profiles. It would be good to let user know the what type of slot is allocated and which job it is allocated for. I don't think it will help a lot to reorganize it to slots + number of slots of that type. In the worst case, that will increase the data size instead.
After an offline discussion with @vthinkxie , I think we can add only this information to `TaskManagerDetailsInfo`. Then, that information will only be returned when user goes into a specific task manager page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
}, {
"hash" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933",
"triggerID" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2aea1ede2fcf41ea68f92dad2efb3936d284269c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876)
* a0c4bc230a6e236de268e7c14a83cb8a446aeb1e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2dc50c51f1d32acaa043173e508a9a3090e2fe03 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800816109
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2dc50c51f1d32acaa043173e508a9a3090e2fe03 (Wed Mar 17 05:53:20 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
}, {
"hash" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933",
"triggerID" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"triggerType" : "PUSH"
}, {
"hash" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15146",
"triggerID" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"triggerType" : "PUSH"
}, {
"hash" : "427a90e5913a3e7561b7c3ea2a85214b5a609969",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15150",
"triggerID" : "427a90e5913a3e7561b7c3ea2a85214b5a609969",
"triggerType" : "PUSH"
}, {
"hash" : "709ccb44a94b9938cf43e5cd0893207544869ce4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15177",
"triggerID" : "709ccb44a94b9938cf43e5cd0893207544869ce4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 709ccb44a94b9938cf43e5cd0893207544869ce4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15177)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a change in pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #15249:
URL: https://github.com/apache/flink/pull/15249#discussion_r598460972
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/taskmanager/TaskManagerDetailsHandler.java
##########
@@ -87,14 +87,14 @@ public TaskManagerDetailsHandler(
final ResourceID taskManagerResourceId =
request.getPathParameter(TaskManagerIdPathParameter.class);
- CompletableFuture<TaskManagerInfo> taskManagerInfoFuture =
- gateway.requestTaskManagerInfo(taskManagerResourceId, timeout);
+ CompletableFuture<TaskManagerInfoWithSlots> taskManagerInfoWithSLotsFuture =
Review comment:
```suggestion
CompletableFuture<TaskManagerInfoWithSlots> taskManagerInfoWithSlotsFuture =
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerDetailsInfo.java
##########
@@ -70,31 +80,39 @@ public TaskManagerDetailsInfo(
memoryConfiguration);
this.taskManagerMetrics = Preconditions.checkNotNull(taskManagerMetrics);
+ this.allocatedSlots = Preconditions.checkNotNull(allocatedSlots);
}
public TaskManagerDetailsInfo(
- TaskManagerInfo taskManagerInfo, TaskManagerMetricsInfo taskManagerMetrics) {
+ TaskManagerInfoWithSlots taskManagerInfoWithSlots,
+ TaskManagerMetricsInfo taskManagerMetrics) {
this(
- taskManagerInfo.getResourceId(),
- taskManagerInfo.getAddress(),
- taskManagerInfo.getDataPort(),
- taskManagerInfo.getJmxPort(),
- taskManagerInfo.getLastHeartbeat(),
- taskManagerInfo.getNumberSlots(),
- taskManagerInfo.getNumberAvailableSlots(),
- taskManagerInfo.getTotalResource(),
- taskManagerInfo.getFreeResource(),
- taskManagerInfo.getHardwareDescription(),
- taskManagerInfo.getMemoryConfiguration(),
+ taskManagerInfoWithSlots.getTaskManagerInfo().getResourceId(),
+ taskManagerInfoWithSlots.getTaskManagerInfo().getAddress(),
+ taskManagerInfoWithSlots.getTaskManagerInfo().getDataPort(),
+ taskManagerInfoWithSlots.getTaskManagerInfo().getJmxPort(),
+ taskManagerInfoWithSlots.getTaskManagerInfo().getLastHeartbeat(),
+ taskManagerInfoWithSlots.getTaskManagerInfo().getNumberSlots(),
+ taskManagerInfoWithSlots.getTaskManagerInfo().getNumberAvailableSlots(),
+ taskManagerInfoWithSlots.getTaskManagerInfo().getTotalResource(),
+ taskManagerInfoWithSlots.getTaskManagerInfo().getFreeResource(),
+ taskManagerInfoWithSlots.getTaskManagerInfo().getHardwareDescription(),
+ taskManagerInfoWithSlots.getTaskManagerInfo().getMemoryConfiguration(),
+ taskManagerInfoWithSlots.getAllocatedSlots(),
taskManagerMetrics);
}
- @JsonProperty(FIELD_NAME_METRICS)
+ @JsonIgnore
Review comment:
This is a bit unrelated. We may consider to have this in a hotfix commit, together with properties in `TaskManagerInfo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a change in pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #15249:
URL: https://github.com/apache/flink/pull/15249#discussion_r595734474
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ClusterResourceStatisticsProvider.java
##########
@@ -50,4 +52,7 @@
/** Get profile of total pending resources. */
ResourceProfile getPendingResource();
+
+ /** Get allocate slots information from the TaskManager with the given instance id. */
+ Collection<TaskManagerSlotInformation> getAllocatedSlotsOf(InstanceID instanceId);
Review comment:
This is not **statistics**.
I'm not entirely sure whether we need to add this interface. Given that it is only used in `FineGrainedSlotManager#getAllocatedSlotsOf`, we may consider to move the implementation of `FineGrainedTaskManagerTracker#getAllocatedSlotsOf` to `FineGrainedSlotManager`.
I'm also fine with adding `getAllocatedSlotsOf` as an shortcut interface. In that case, we might consider to 1) move it to `TaskManagerResourceInfoProvider`, and 2) provide a default implementation basing on `getRegisteredTaskManager`.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManager.java
##########
@@ -717,6 +717,12 @@ public ResourceProfile getFreeResourceOf(InstanceID instanceID) {
return taskExecutorManager.getTotalFreeResourcesOf(instanceID);
}
+ @Override
+ public Collection<TaskManagerSlotInformation> getAllocatedSlotsOf(InstanceID instanceID) {
+ // This information is only valid for fine-grained resource management.
Review comment:
I would say it's currently not supported for this slot manager. The information should always be valid.
Same for `SlotManagerImpl`.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
##########
@@ -70,6 +71,8 @@
ResourceProfile getFreeResourceOf(InstanceID instanceID);
+ Collection<TaskManagerSlotInformation> getAllocatedSlotsOf(InstanceID instanceID);
Review comment:
This interface exposes `TaskManagerSlotInformation`, which should be internal to slot manager.
I'd suggest to return `SlotInfo` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #15249:
URL: https://github.com/apache/flink/pull/15249#discussion_r597124183
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java
##########
@@ -636,6 +637,15 @@ public ResourceProfile getFreeResourceOf(InstanceID instanceID) {
return taskManagerTracker.getRegisteredResourceOf(instanceID);
}
+ @Override
+ public Collection<SlotInfo> getAllocatedSlotsOf(InstanceID instanceID) {
+ return taskManagerTracker.getRegisteredTaskManager(instanceID)
+ .map(TaskManagerInfo::getAllocatedSlots).map(Map::values)
+ .orElse(Collections.emptyList()).stream()
+ .map(slot -> new SlotInfo(slot.getJobId(), slot.getResourceProfile()))
+ .collect(Collectors.toList());
Review comment:
But why bother with slots in the first place? Isn't the whole point for fine-grained resource management to not really bother with slots but _resources_ instead, so why then expose it as slots again in the UI?
Why not just say "Job A has allocated X memory and Y CPUs on TM Z to run N tasks."
That is some really digestible information.
What value does it bring to know this instead:
"Job as has N slots on TM Z, where slot 1 uses X_1 memory any Y_1 cpus, and slot 2 uses X_2 memory and Y_2 cpus, and ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
}, {
"hash" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933",
"triggerID" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"triggerType" : "PUSH"
}, {
"hash" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15146",
"triggerID" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"triggerType" : "PUSH"
}, {
"hash" : "427a90e5913a3e7561b7c3ea2a85214b5a609969",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "427a90e5913a3e7561b7c3ea2a85214b5a609969",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0c4bc230a6e236de268e7c14a83cb8a446aeb1e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933)
* 011a96e4641ba00f16db6d6f6e300043e8dcf312 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15146)
* 427a90e5913a3e7561b7c3ea2a85214b5a609969 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
}, {
"hash" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933",
"triggerID" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"triggerType" : "PUSH"
}, {
"hash" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15146",
"triggerID" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"triggerType" : "PUSH"
}, {
"hash" : "427a90e5913a3e7561b7c3ea2a85214b5a609969",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15150",
"triggerID" : "427a90e5913a3e7561b7c3ea2a85214b5a609969",
"triggerType" : "PUSH"
}, {
"hash" : "709ccb44a94b9938cf43e5cd0893207544869ce4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15177",
"triggerID" : "709ccb44a94b9938cf43e5cd0893207544869ce4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 011a96e4641ba00f16db6d6f6e300043e8dcf312 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15146)
* 427a90e5913a3e7561b7c3ea2a85214b5a609969 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15150)
* 709ccb44a94b9938cf43e5cd0893207544869ce4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15177)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
}, {
"hash" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933",
"triggerID" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"triggerType" : "PUSH"
}, {
"hash" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15146",
"triggerID" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"triggerType" : "PUSH"
}, {
"hash" : "427a90e5913a3e7561b7c3ea2a85214b5a609969",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15150",
"triggerID" : "427a90e5913a3e7561b7c3ea2a85214b5a609969",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0c4bc230a6e236de268e7c14a83cb8a446aeb1e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933)
* 011a96e4641ba00f16db6d6f6e300043e8dcf312 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15146)
* 427a90e5913a3e7561b7c3ea2a85214b5a609969 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15150)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2dc50c51f1d32acaa043173e508a9a3090e2fe03 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867)
* 2aea1ede2fcf41ea68f92dad2efb3936d284269c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #15249:
URL: https://github.com/apache/flink/pull/15249#discussion_r597124183
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java
##########
@@ -636,6 +637,15 @@ public ResourceProfile getFreeResourceOf(InstanceID instanceID) {
return taskManagerTracker.getRegisteredResourceOf(instanceID);
}
+ @Override
+ public Collection<SlotInfo> getAllocatedSlotsOf(InstanceID instanceID) {
+ return taskManagerTracker.getRegisteredTaskManager(instanceID)
+ .map(TaskManagerInfo::getAllocatedSlots).map(Map::values)
+ .orElse(Collections.emptyList()).stream()
+ .map(slot -> new SlotInfo(slot.getJobId(), slot.getResourceProfile()))
+ .collect(Collectors.toList());
Review comment:
But why bother with slots in the first place? Isn't the whole point for fine-grained resource management to not really bother with slots but _resources_ instead, so why then expose it as slots again in the UI?
Why not just say "Job A has allocated X memory and Y CPUs on TM Z to run N tasks."
What value does it bring to know this instead:
"Job as has N slots on TM Z, where slot 1 uses X_1 memory any Y_1 cpus, and slot 2 uses X_2 memory and Y_2 cpus, and ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
}, {
"hash" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2aea1ede2fcf41ea68f92dad2efb3936d284269c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876)
* a0c4bc230a6e236de268e7c14a83cb8a446aeb1e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vthinkxie commented on a change in pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #15249:
URL: https://github.com/apache/flink/pull/15249#discussion_r597360427
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java
##########
@@ -636,6 +637,15 @@ public ResourceProfile getFreeResourceOf(InstanceID instanceID) {
return taskManagerTracker.getRegisteredResourceOf(instanceID);
}
+ @Override
+ public Collection<SlotInfo> getAllocatedSlotsOf(InstanceID instanceID) {
+ return taskManagerTracker.getRegisteredTaskManager(instanceID)
+ .map(TaskManagerInfo::getAllocatedSlots).map(Map::values)
+ .orElse(Collections.emptyList()).stream()
+ .map(slot -> new SlotInfo(slot.getJobId(), slot.getResourceProfile()))
+ .collect(Collectors.toList());
Review comment:
"Job as has N slots on TM Z, where slot 1 uses X_1 memory any Y_1 cpus, and slot 2 uses X_2 memory and Y_2 cpus, and ..." could be aggregated and get "Job A has allocated X memory and Y CPUs on TM Z to run N tasks."
while it cannot be pushed backward.
Since TM and resources are implemented on a slots basis, the interface layer should expose atomic properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #15249:
URL: https://github.com/apache/flink/pull/15249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2dc50c51f1d32acaa043173e508a9a3090e2fe03 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867)
* 2aea1ede2fcf41ea68f92dad2efb3936d284269c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
}, {
"hash" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933",
"triggerID" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"triggerType" : "PUSH"
}, {
"hash" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0c4bc230a6e236de268e7c14a83cb8a446aeb1e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933)
* 011a96e4641ba00f16db6d6f6e300043e8dcf312 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
}, {
"hash" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14933",
"triggerID" : "a0c4bc230a6e236de268e7c14a83cb8a446aeb1e",
"triggerType" : "PUSH"
}, {
"hash" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15146",
"triggerID" : "011a96e4641ba00f16db6d6f6e300043e8dcf312",
"triggerType" : "PUSH"
}, {
"hash" : "427a90e5913a3e7561b7c3ea2a85214b5a609969",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15150",
"triggerID" : "427a90e5913a3e7561b7c3ea2a85214b5a609969",
"triggerType" : "PUSH"
}, {
"hash" : "709ccb44a94b9938cf43e5cd0893207544869ce4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15177",
"triggerID" : "709ccb44a94b9938cf43e5cd0893207544869ce4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 427a90e5913a3e7561b7c3ea2a85214b5a609969 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15150)
* 709ccb44a94b9938cf43e5cd0893207544869ce4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15177)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
}, {
"hash" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876",
"triggerID" : "2aea1ede2fcf41ea68f92dad2efb3936d284269c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2aea1ede2fcf41ea68f92dad2efb3936d284269c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14876)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15249:
URL: https://github.com/apache/flink/pull/15249#issuecomment-800824909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867",
"triggerID" : "2dc50c51f1d32acaa043173e508a9a3090e2fe03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2dc50c51f1d32acaa043173e508a9a3090e2fe03 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14867)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org