You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/12/01 21:00:12 UTC
Review Request 28570: Assigned host path for persistent volumes
allowing containerizer to prepare the workdir.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28570/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-2031
https://issues.apache.org/jira/browse/MESOS-2031
Repository: mesos-git
Description
-------
Assigned host path for persistent volumes allowing containerizer to prepare the workdir.
Diffs
-----
include/mesos/mesos.proto 0085aba923b53c37f31d5af30b2eeec5d533d8ba
src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
src/slave/slave.cpp ed63dedbda0bf548a95de7d39002ac56a29303e5
Diff: https://reviews.apache.org/r/28570/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 28570: Assigned host path for persistent volumes
allowing containerizer to prepare the workdir.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28570/#review63434
-----------------------------------------------------------
src/slave/slave.hpp
<https://reviews.apache.org/r/28570/#comment105685>
Why not just pass by value? Seems to match exactly what you want to do with clearer intent.
- Timothy Chen
On Dec. 1, 2014, 8 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28570/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 8 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-2031
> https://issues.apache.org/jira/browse/MESOS-2031
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Assigned host path for persistent volumes allowing containerizer to prepare the workdir.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 0085aba923b53c37f31d5af30b2eeec5d533d8ba
> src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
> src/slave/slave.cpp ed63dedbda0bf548a95de7d39002ac56a29303e5
>
> Diff: https://reviews.apache.org/r/28570/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>