You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> on 2007/09/13 17:25:03 UTC
Re: [PATCH] For consistency mark some dates and strings for localization
2007-09-10 22:32:11 Arfrever Frehtes Taifersar Arahesis napisał(a):
> 2007-09-10 21:46:02 Erik Huelsmann napisał(a):
> > On 9/10/07, Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> wrote:
> > > 2007-09-10 21:18:32 Karl Fogel napisał(a):
> > > > So right now, I think it wouldn't be applied. If we're missing
> > > > something important, please let us know.
> > >
> > > Thanks for reply.
> > >
> > > %c is too long for `svn ls -v`. Its localization would be also consistent with e.g. `ls -l`.
> > >
> > > I don't have strong arguments for localization of "%a %b %e %H:%M:%S %Y", but e.g. in
> > > Simplified Chinese the order is "year month day" instead of "month day year", so maybe Cauchy
> > > would like to localize it.
> > >
> > > No problem in case of "txn" and "rev".
> > >
> > > For me, the most important would be the localization of dates in `svn ls -v`.
> >
> > Understood. Maybe you could have a look at how ls localized it's
> > output? Did they do it the way you do, or do they use some other %
> > format specifier from strftime?
>
> <Coreutils-6.9>/src/ls.c: Lines 672-693:
> /* strftime formats for non-recent and recent files, respectively, in
> -l output. */
>
> static char const *long_time_format[2] =
> {
> /* strftime format for non-recent files (older than 6 months), in
> -l output. This should contain the year, month and day (at
> least), in an order that is understood by people in your
> locale's territory. Please try to keep the number of used
> screen columns small, because many people work in windows with
> only 80 columns. But make this as wide as the other string
> below, for recent files. */
> N_("%b %e %Y"),
> /* strftime format for recent files (younger than 6 months), in -l
> output. This should contain the month, day and time (at
> least), in an order that is understood by people in your
> locale's territory. Please try to keep the number of used
> screen columns small, because many people work in windows with
> only 80 columns. But make this as wide as the other string
> above, for non-recent files. */
> N_("%b %e %H:%M")
> };
So what do you think about this small, reduced patch, which I'm attaching now?
As mentioned earlier, localization of dates in `svn ls -v` would be consistent
with localization of dates in `ls -l`.
[[[
Mark dates for localization.
* subversion/svn/list-cmd.c
(print_dirent): Mark dates for localization.
Patch by: Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>
]]]
--
Arfrever Frehtes Taifersar Arahesis
Re: [PATCH] For consistency mark some dates and strings for localization
Posted by Karl Fogel <kf...@red-bean.com>.
Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> writes:
>> The patch below looks good to me -- I guess the translator would just
>> rearrange the % codes in whatever order was appropriate?
>>
>> I'd prefer for someone more familiar with translation/localization
>> issues to agree before I commit, though, in case I'm missing something
>> obvious.
>
> Fortunately you aren't missing anything :) .
> I confirm that that patch works correctly with Polish translation.
r26588. We'll see if anyone thinks otherwise :-).
Thanks for the patch,
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] For consistency mark some dates and strings for localization
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
2007-09-14 03:22:02 Karl Fogel napisał(a):
> Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> writes:
> > So what do you think about this small, reduced patch, which I'm
> > attaching now? As mentioned earlier, localization of dates in `svn
> > ls -v` would be consistent with localization of dates in `ls -l`.
>
> The patch below looks good to me -- I guess the translator would just
> rearrange the % codes in whatever order was appropriate?
>
> I'd prefer for someone more familiar with translation/localization
> issues to agree before I commit, though, in case I'm missing something
> obvious.
Fortunately you aren't missing anything :) .
I confirm that that patch works correctly with Polish translation.
- --
Arfrever Frehtes Taifersar Arahesis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
iD8DBQFG6gTD/axNJ4Xo/ZERAht3AJ4pZS3PLuppSduAYxilgsQ1tBntwwCeNOV1
obPHaOKgo+K7nJ6sTu/cvBM=
=uNob
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] For consistency mark some dates and strings for localization
Posted by Karl Fogel <kf...@red-bean.com>.
Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> writes:
> So what do you think about this small, reduced patch, which I'm
> attaching now? As mentioned earlier, localization of dates in `svn
> ls -v` would be consistent with localization of dates in `ls -l`.
The patch below looks good to me -- I guess the translator would just
rearrange the % codes in whatever order was appropriate?
I'd prefer for someone more familiar with translation/localization
issues to agree before I commit, though, in case I'm missing something
obvious. Anyone?
-K
> [[[
> Mark dates for localization.
>
> * subversion/svn/list-cmd.c
> (print_dirent): Mark dates for localization.
>
> Patch by: Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>
> ]]]
>
> Index: subversion/svn/list-cmd.c
> ===================================================================
> --- subversion/svn/list-cmd.c (revision 26580)
> +++ subversion/svn/list-cmd.c (working copy)
> @@ -87,12 +87,12 @@
> && apr_time_sec(dirent->time - now) < (365 * 86400 / 2))
> {
> apr_err = apr_strftime(timestr, &size, sizeof(timestr),
> - "%b %d %H:%M", &exp_time);
> + _("%b %d %H:%M"), &exp_time);
> }
> else
> {
> apr_err = apr_strftime(timestr, &size, sizeof(timestr),
> - "%b %d %Y", &exp_time);
> + _("%b %d %Y"), &exp_time);
> }
>
> /* if that failed, just zero out the string and print nothing */
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org