You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/30 09:29:41 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39310: [MINOR][CONNECT][DOC] Add missing docstring for function `col`
zhengruifeng opened a new pull request, #39310:
URL: https://github.com/apache/spark/pull/39310
### What changes were proposed in this pull request?
Add missing doc for function `col`
### Why are the changes needed?
the docstring is missing
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
existing ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39310: [MINOR][CONNECT][DOC] Add missing docstring for function `col`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #39310:
URL: https://github.com/apache/spark/pull/39310#discussion_r1059556997
##########
python/pyspark/sql/connect/functions.py:
##########
@@ -161,9 +161,15 @@ def col(col: str) -> Column:
return Column(ColumnReference(col))
+col.__doc__ = pysparkfuncs.col.__doc__
+
+
column = col
+column.__doc__ = pysparkfuncs.column.__doc__
+
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39310: [MINOR][CONNECT][DOC] Add missing docstring for function `col`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #39310:
URL: https://github.com/apache/spark/pull/39310#discussion_r1059556997
##########
python/pyspark/sql/connect/functions.py:
##########
@@ -161,9 +161,15 @@ def col(col: str) -> Column:
return Column(ColumnReference(col))
+col.__doc__ = pysparkfuncs.col.__doc__
+
+
column = col
+column.__doc__ = pysparkfuncs.column.__doc__
+
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39310: [MINOR][CONNECT][DOC] Add missing docstring for function `col`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39310:
URL: https://github.com/apache/spark/pull/39310#issuecomment-1368137275
Build: https://github.com/zhengruifeng/spark/actions/runs/3809846744/jobs/6481511410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39310: [MINOR][CONNECT][DOC] Add missing docstring for function `col`
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39310:
URL: https://github.com/apache/spark/pull/39310#issuecomment-1368148917
thank you @dongjoon-hyun @HyukjinKwon , merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #39310: [MINOR][CONNECT][DOC] Add missing docstring for function `col`
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #39310: [MINOR][CONNECT][DOC] Add missing docstring for function `col`
URL: https://github.com/apache/spark/pull/39310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org