[GitHub] [pulsar] cckellogg commented on a change in pull request #4701: Fix: Add kubernetes namespace to function instance url

[GitBox <gi...@apache.org>]

cckellogg commented on a change in pull request #4701: Fix: Add kubernetes namespace to function instance url
URL: https://github.com/apache/pulsar/pull/4701#discussion_r302029328
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java
 ##########
 @@ -993,6 +993,10 @@ private static String createJobName(String tenant, String namespace, String func
         return "pf-" + tenant + "-" + namespace + "-" + functionName;
     }
 
+    private static String getServiceUrl(String jobName, String jobNamespace, int instanceId) {
+        return String.format("%s-%d.%s.%s", jobName, instanceId, jobName, jobNamespace);
 
 Review comment:
   Does there need to be `svc.cluster.local` after the namespace? https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/#namespaces-and-dns 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services