You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/10/15 04:22:35 UTC

[GitHub] [activemq] lucastetreault opened a new pull request, #920: [AMQ-9107] Add a test for offline durable subscriptions

lucastetreault opened a new pull request, #920:
URL: https://github.com/apache/activemq/pull/920

   As per Matt's request [here](https://github.com/apache/activemq/pull/908#discussion_r994672165), adding a test to make sure offline durable subscribers can be added/removed as usual. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq] jbonofre closed pull request #920: [AMQ-9107] Add a test for offline durable subscriptions

Posted by GitBox <gi...@apache.org>.
jbonofre closed pull request #920: [AMQ-9107] Add a test for offline durable subscriptions
URL: https://github.com/apache/activemq/pull/920


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq] lucastetreault commented on pull request #920: [AMQ-9107] Add a test for offline durable subscriptions

Posted by GitBox <gi...@apache.org>.
lucastetreault commented on PR #920:
URL: https://github.com/apache/activemq/pull/920#issuecomment-1283021251

   @mattrpav, I added a test case to the MBeanTest. Hopefully more in line with what you were thinking. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq] lucastetreault commented on pull request #920: [AMQ-9107] Add a test for offline durable subscriptions

Posted by GitBox <gi...@apache.org>.
lucastetreault commented on PR #920:
URL: https://github.com/apache/activemq/pull/920#issuecomment-1279781189

   Pushed an empty commit to trigger the tests again. All the tests passed on my own Jenkins for this commit 🤷‍♂️


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq] jbonofre commented on pull request #920: [AMQ-9107] Add a test for offline durable subscriptions

Posted by GitBox <gi...@apache.org>.
jbonofre commented on PR #920:
URL: https://github.com/apache/activemq/pull/920#issuecomment-1296566972

   LGTM, thanks. I will manually merge to squash the two commits in one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org