You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/16 07:34:00 UTC

[jira] [Commented] (FLINK-7454) update 'Monitoring Current Event Time' section of Flink doc

    [ https://issues.apache.org/jira/browse/FLINK-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128447#comment-16128447 ] 

ASF GitHub Bot commented on FLINK-7454:
---------------------------------------

GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/4547

    [FLINK-7454][docs] update 'Monitoring Current Event Time' section of Flink doc

    **(The sections below can be removed for hotfixes of typos)**
    
    ## What is the purpose of the change
    
    Since FLINK-3427 is done, there's no need to have the following doc in https://ci.apache.org/projects/flink/flink-docs-release-1.3/monitoring/debugging_event_time.html#monitoring-current-event-time
    
    "There are plans (see FLINK-3427) to show the current low watermark for each operator in the Flink web interface.
    Until this feature is implemented the current low watermark for each task can be accessed through the metrics system."
    
    We can replace it with something like "Low watermarks of each task can be accessed either from Flink web interface or Flink metric system."
    
    ## Brief change log
    
    Update doc.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-7454

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4547.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4547
    
----
commit ac0b4d22fde763dde62b26ed9a022d537bb29e58
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-04T03:59:02Z

    FLINK-7367 Parameterize FlinkKinesisProducer on RecordMaxBufferedTime, MaxConnections, RequestTimeout, and more

commit 0fa8aff08dcc1018c654e79e35838d42cb4b21b6
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-07T18:54:44Z

    reformat code

commit c8d8f58e44185db7a5eaf590ab444da499ae966b
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-08T23:02:13Z

    FLINK-7367 Parameterize more configs for FlinkKinesisProducer (RecordMaxBufferedTime, MaxConnections, RequestTimeout, etc)

commit a9dd261fb9e8009687891952d1d1d44d4548ee8e
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-08T23:10:20Z

    add license to file

commit 420cb6839206b574b57614be12f17ebd058210ba
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-08T23:41:54Z

    update doc

commit 63fbb23775b6fab7ff18ca445880c57910faa3fe
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-08T23:43:25Z

    update doc

commit 6c73370ace8ddfdc977c9e9464ffa12dd6562829
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-08T23:45:08Z

    update doc

commit 6bca9970276d904e19b1ce710a33643365c5427c
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-08T23:47:04Z

    removed unused string

commit d108df3bc32f548b525918e0e4a597a5abf034a8
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-08T23:49:16Z

    update doc

commit 0068a5442d26beb932aaf769514d06a77553d58e
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-08T23:50:09Z

    update doc

commit cfdeefa2229375da554fb3da525ba2b77fc3089e
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-09T17:13:52Z

    remove deprecated keys

commit 087cc1a5637479cf93cc0f74344daf7f70589242
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-09T17:24:22Z

    Merge branch 'master' into FLINK-7363

commit f8f80d010b1dfb908221cdd5ec12f4e5faaf1a77
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-09T17:32:31Z

    revert changes

commit acd9dd188659b627cc28dc63836eaa1a9fb433ee
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-10T07:04:20Z

    deprecate ProducerConfigConstants, and move configs to KinesisConfigUtil

commit 8e60f33a50220fda342936f64ece3098a4ad1155
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-11T16:55:50Z

    fix key renaming issues for savepoints

commit cb21fd1871ffe402b0b7246299626c11f92a87a1
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-14T06:09:49Z

    add @deprecated tag to javadoc

commit 04a7d5789d66dc808a3952eb10fbdde25b653bf1
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-14T06:18:27Z

    remove KinesisProducerConfiguration from class field

commit 5cd0f7b2e857e93012cfc8e623894a0d7a0bf91f
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-16T06:00:36Z

    add back code to explicitly set aws region

commit 516bfda007527ef9fb7c63fcc0bf7fc14b52513a
Author: Bowen Li <bo...@gmail.com>
Date:   2017-08-16T07:29:22Z

    FLINK-7454 update 'Monitoring Current Event Time' section of Flink doc

----


> update 'Monitoring Current Event Time' section of Flink doc
> -----------------------------------------------------------
>
>                 Key: FLINK-7454
>                 URL: https://issues.apache.org/jira/browse/FLINK-7454
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 1.3.2
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Minor
>             Fix For: 1.4.0, 1.3.3
>
>
> Since FLINK-3427 is done, there's no need to have the following doc in https://ci.apache.org/projects/flink/flink-docs-release-1.3/monitoring/debugging_event_time.html#monitoring-current-event-time
> "There are plans (see FLINK-3427) to show the current low watermark for each operator in the Flink web interface.
> Until this feature is implemented the current low watermark for each task can be accessed through the metrics system."
> We can replace it with something like "Low watermarks of each task can be accessed either from Flink web interface or Flink metric system."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)