You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "susiwen8 (via GitHub)" <gi...@apache.org> on 2023/02/15 16:17:27 UTC

[GitHub] [echarts] susiwen8 opened a new pull request, #18276: fix(dataset): object source contains `length` breaks render

susiwen8 opened a new pull request, #18276:
URL: https://github.com/apache/echarts/pull/18276

   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Replace `each` by `keys` to retrive correct dimension from object source.
   
   
   
   ### Fixed issues
   
   - close #18050
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <img width="749" alt="Screenshot 2023-02-16 at 00 16 32" src="https://user-images.githubusercontent.com/20318608/219086747-98aeef3a-b130-4c74-9b02-cfe37a927632.png">
   
   
   
   
   ### After: How does it behave after the fixing?
   
   <img width="763" alt="Screenshot 2023-02-16 at 00 15 57" src="https://user-images.githubusercontent.com/20318608/219086801-64fd2d15-9e89-4280-a85a-946c1c2791ce.png">
   
   
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   
   ## Misc
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   
   `test/dataset-category.html`
   
   ## Others
   
   ### Merging options
   
   - [x] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Ovilia merged pull request #18276: fix(dataset): object source contains `length` breaks render

Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia merged PR #18276:
URL: https://github.com/apache/echarts/pull/18276


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #18276: fix(dataset): object source contains `length` breaks render

Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #18276:
URL: https://github.com/apache/echarts/pull/18276#issuecomment-1431627286

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #18276: fix(dataset): object source contains `length` breaks render

Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #18276:
URL: https://github.com/apache/echarts/pull/18276#issuecomment-1432765346

   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org